Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 336268 - [Memory Browser] Need to set NULL selection when the tab for the actve rendering is closed
Summary: [Memory Browser] Need to set NULL selection when the tab for the actve render...
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-memory (show other bugs)
Version: 8.0   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 8.0   Edit
Assignee: Randy Rohrbach CLA
QA Contact: Ted Williams CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-03 13:18 EST by Alain Lee CLA
Modified: 2011-05-13 11:06 EDT (History)
2 users (show)

See Also:
Randy.Rohrbach: review? (john.cortell)

Attachments
Patch to set NULL selection the activing rendering is closed (895 bytes, patch)
2011-02-08 17:34 EST, Alain Lee CLA 		cdtdoug: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alain Lee CLA 2011-02-03 13:18:13 EST 
When Memory Browser have multiple tabs and a tab is closed, the Active Rendering is switched to the next available tab and a Selection Change event is sent. However, it there is only one tab and the tab is closed, no Selection Change event is sent and the Active Rendering is set to NULL but the selection is not updated. Whoever needs to monitor the selection in Memory Browser will not know that the Active Rendering has been changed to NULL.
Comment 1 Alain Lee CLA 2011-02-08 17:34:20 EST 
Created attachment 188556 [details]
Patch to set NULL selection the activing rendering is closed
Comment 2 Randy Rohrbach CLA 2011-02-09 12:50:43 EST 
I'll take this one.
Just q quick update.
Randy
Comment 3 Randy Rohrbach CLA 2011-02-09 13:41:24 EST 
I checked in this change to 8.0

Randy
781-364-2226
Comment 4 CDT Genie CLA 2011-02-10 09:28:08 EST 
*** cdt cvs genie on behalf of rarohrba ***
Bug 336268 create empty selection when last tab is disposed.

[*] MemoryBrowser.java 1.38 http://dev.eclipse.org/viewcvs/index.cgi/org.eclipse.cdt/memory/org.eclipse.cdt.debug.ui.memory.memorybrowser/src/org/eclipse/cdt/debug/ui/memory/memorybrowser/MemoryBrowser.java?root=Tools_Project&r1=1.37&r2=1.38