Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 336254 - Externalize String Wizard can lose all edited substitution keys
Summary: Externalize String Wizard can lose all edited substitution keys
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows 7
: P3 trivial (vote)
Target Milestone: 4.10 M3   Edit
Assignee: Vikas Chandra CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-03 11:13 EST by Etienne Reichenbach CLA
Modified: 2018-11-20 03:47 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Etienne Reichenbach CLA 2011-02-03 11:13:50 EST 
Build Identifier: I20100608-0911

Loss of all edited substitution keys if the steps described are executed.

Reproducible: Always

Steps to Reproduce:

1 open an xml file to externalize
2 open the externalize Strings wizard
3 in the Strings to externalize table, edit a substitution key, by removing the content (empty string)
4 click on an other string to externalize

What happens: all edited Substitutions keys are lost! It is only possible to cancel the wizard
Comment 1 Ankur Sharma CLA 2011-02-07 03:57:10 EST 
How you are invoking the externalize string wizard?
Is it from WTP's XML Editor? Or did you mean the Externalize String for plugin.xml?

Need this info to direct the report to right bucket as I doubt PDE is the reason here.
Comment 2 Etienne Reichenbach CLA 2011-02-07 05:12:24 EST 
(In reply to comment #1)
> How you are invoking the externalize string wizard?
> Is it from WTP's XML Editor? Or did you mean the Externalize String for
> plugin.xml?
> 
> Need this info to direct the report to right bucket as I doubt PDE is the
> reason here.

yes, I mean the Externalize String for plugin.xml
Comment 3 Ankur Sharma CLA 2011-02-07 05:31:42 EST 
Got it now. Able to reproduce it in I20110201-0800.
Comment 4 Ankur Sharma CLA 2011-02-07 11:29:44 EST 
Not really a bug. Its working as designed (right or wrong). When you delete a substitution key, the wizard will filter to that particular key - forcing the user to enter a key before proceeding. As soon a key is entered, things  are back to normal (so to say).

I understand it did not get conveyed intuitively to the user. Perhaps a better error will help. We should suffix the current message with "Provide a valid key to proceed." The current message actually suggest to revert to the old key.
Comment 5 Eclipse Genie CLA 2018-10-26 01:44:02 EDT 
New Gerrit change created: https://git.eclipse.org/r/131483
Comment 7 Vikas Chandra CLA 2018-11-20 03:47:15 EST 
verified on
Version: 2018-12 (4.10)
Build id: I20181119-0600