Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 336250 - [zOS] Package target copies wrong script for ACVersion.sh
Summary: [zOS] Package target copies wrong script for ACVersion.sh
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: PC other
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Mike Reid CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-03 11:02 EST by Mike Reid CLA
Modified: 2016-05-05 11:00 EDT (History)
3 users (show)

See Also:
kathy: pmc_approved? (oec)
kathy: pmc_approved? (ernest)
kathy: pmc_approved+
jgwest: pmc_approved+
jerome.bozier: pmc_approved+
jcayne: review+


Attachments
Patch (1.02 KB, patch)
2011-02-03 11:06 EST, Mike Reid CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Reid CLA 2011-02-03 11:02:48 EST
The package target in the zOS build incorrectly copies the ACStop.sh and names it ACVersion.sh. The result is that the ACVersion.sh script actually stops the AC!
Comment 1 Mike Reid CLA 2011-02-03 11:06:40 EST
Created attachment 188251 [details]
Patch

Patch attached that copies the correct file.
Comment 2 Mike Reid CLA 2011-02-03 13:20:22 EST
Joel, can you review patch?
Comment 3 Joel Cayne CLA 2011-02-03 13:49:02 EST
Patch looks good.
Comment 4 Mike Reid CLA 2011-02-03 14:22:40 EST
I would like to request that the following defect be considered for PMC
approval for 4.7.2.

1.  Explain why you believe this is a stop-ship defect. How does the defect
manifest itself, and how will users of TPTP / consuming products be affected if
the defect is not fixed?

If a user on a downstream product supporting zOS tries to execute 'ACVersion.sh', it will stop the running AC instead of reporting the version number, potentially interrupting a profiling session or other work.

This is a bad usability flaw for the user, particularly if a profiling session is in progress.

2. Is there a work-around? If so, why do you believe the work-around is
insufficient?

A user can manually invoke 'ACServer -v' after setting appropriate environment variables, but they have no way of knowing to do this until they discover the problem first-hand.

3. Is this a regression or API breakage? Explain.

No, this behaviour seems to be in older releases as well.

4. Does this require new API?

No.

5. Who performed the code review?

Joel Cayne.

6. Is there a test case attached to the bugzilla record?

n/a

7. What is the nature of the fix?  What is the risk associated with this fix?

Packaging change. Low risk; only platform affected is zOS.

8. Is this fix related to any standards that TPTP adheres to? If so, who has
validated that the fix continues to adhere to the standard?

No.
Comment 5 Kathy Chan CLA 2011-02-03 14:30:44 EST
Requesting PMC approval for TPTP 4.7.2.
Comment 6 Mike Reid CLA 2011-02-03 15:42:57 EST
Checked into HEAD w/ PMC approval.
Comment 7 Mike Reid CLA 2011-02-03 15:43:11 EST
Resolving.
Comment 8 Mike Reid CLA 2011-04-04 11:05:58 EDT
Closing.