Community
Participate
Working Groups
I thought we had a bug report for this but I can't find one so I will open this. As Pascal mentions here: http://dev.eclipse.org/mhonarc/lists/p2-dev/msg03773.html The metadata generator bundle has been deprecated (in favour of the publisher bundle) for 2 releases and now it is time to remove it from the builds. In order to ensure the removal goes smoothly and doesn't break anyone the following should happen: - announce the intended removal on cross-projects-dev mailing list - update wiki documentation to point to publisher (and maybe reference this bug?) - include entries in the migration guide to help users with the migration - if the application extension points are being moved to the publisher, we need to ensure they still work - get Kim to run a test build to ensure the SDK is ok with the change Anything else? Once the bundle is removed we should go through the metadata generator bug reports and close them as invalid only after we ensure that the behaviour works ok with the publisher. There are generator-specific classes in the p2.tests that we can also remove. We should also do a search to see if any other tests are using the same testdata and if not, then remove that as well.
There is bug 291696. There was a bunch of work done in PDE/Build and the publisher to make the switch to the publisher as transparent as possible to any users. There is a compatibility layer to support 3.4 era builds which originally ran using the metadata generator. There is an org.eclipse.equinox.p2.publisher.EclipseGenerator application which should be analogous to the org.eclipse.equinox.p2.metadata.generator.EclipseGenerator application. The final thing that wasn't done last year to make the change completely transparent was for the publisher to define a "org.eclipse.equinox.p2.metadata.generator.EclipseGenerator" application which calls the publisher.EclipseGenerator.
I have removed all references to the bundle. However I have not "moved" the new extension and I'm not really inclined to do it.
Pascal, I noticed that the p2.user.ui feature still references this bundle. Could you fix this? Otherwise the build will fail since the bundle no longer exists in the p2.map.
Good catch. Thx. If the machines are free, maybe we can run a quick build (no tests though)
Sure, I've started a test build
Created attachment 189994 [details] compile logs Pascal, the p2 tests still refer to the metadata generator which has resulted in compile errors. Could you please remove all the references?
Fixed in HEAD.
*** Bug 291696 has been marked as a duplicate of this bug. ***
Can this be closed?
Yes, the metadata generator is gone.
Pascal, there is still a generator package in the tests. Is this still applicable? Did you also remove references from the documentation?
I opened bug 344157 to address the remaining questions.
New Gerrit change created: https://git.eclipse.org/r/68642
Commit 439356b40487f691fc68c0c90eedce5d73d65c0f simply replaced calls to MetadataGeneratorHelper with calls to PublisherHelper creating tests that duplicate existing ones. In https://git.eclipse.org/r/68642, I've removed these duplicates so there is no references/logic related to MetadataGeneratorHelper any more. Looking forward for your 'Code-Review +1', +2 is better ;-)
Gerrit change https://git.eclipse.org/r/68642 was merged to [master]. Commit: http://git.eclipse.org/c/equinox/rt.equinox.p2.git/commit/?id=ae7c096597eaaed93d9832a41f3065792f9b41c5
