Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 336188 - [client] Look at using plugins for File Service
Summary: [client] Look at using plugins for File Service
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 enhancement (vote)
Target Milestone: 0.2   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-02 23:31 EST by Simon Kaegi CLA
Modified: 2011-09-01 11:43 EDT (History)
3 users (show)

See Also:

Attachments
Work in progress (5.82 KB, patch)
2011-02-11 17:01 EST, John Arthorne CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Kaegi CLA 2011-02-02 23:31:09 EST 
At the moment our IFileService implementation is running in page as a local service and tied to the web server providing Orion. This is probably not a good assumption long term nd we should look at running the implementation as a Plugin.
Comment 1 John Arthorne CLA 2011-02-11 17:01:01 EST 
Created attachment 188820 [details]
Work in progress

I have made some progress, but things are broken in the current state so I don't want to commit it. Simon feel free to take a look. Basically I wanted to get fileClient.js to work in both the plugin use case, and in the old case where the file service was registered manually by the various pages.
Comment 2 Szymon Brandys CLA 2011-02-14 11:09:44 EST 
File Service and User Service should be hosted on the same site. I raised a bug for using plug-ins for User Service too.
Comment 3 Szymon Brandys CLA 2011-02-14 11:10:10 EST 
(In reply to comment #2)
> File Service and User Service should be hosted on the same site. I raised a bug
> for using plug-ins for User Service too.

See Bug 337104.
Comment 4 Malgorzata Janczarska CLA 2011-02-14 12:32:02 EST 
What are you planning to do with all the callback functions that are normally send to the file service? "updateFunction", "onCreate", "onLoad" etc? We can't pass functions as arguments to services provided by plugin.
Comment 5 Simon Kaegi CLA 2011-02-15 10:30:14 EST 
The individual service calls return a "then-able promise". The Serviceregistry also lets service providers fire events and consumers register for those events.
Comment 6 John Arthorne CLA 2011-03-04 15:16:29 EST 
This work has been released. There will be some follow-on work in M7 related to authorization for the file plugin, and for supporting more than one file plugin installed at once.