Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 336129 - Remove org.eclipse.core.runtime.compatibility.auth from 4.1
Summary: Remove org.eclipse.core.runtime.compatibility.auth from 4.1
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 4.1   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 4.2 M3   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-02 14:00 EST by John Arthorne CLA
Modified: 2012-11-06 22:43 EST (History)
6 users (show)

See Also:


Attachments
Fix against R4_HEAD (822 bytes, patch)
2011-02-02 14:02 EST, John Arthorne CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2011-02-02 14:00:02 EST
This bundle contains encryption code that was long ago replaced by Equinox secure storage.  We should just remove this fragment from 4.1, since it causes export problems for some people shipping eclipse due to the presence of encryption (which is why it was split into a separate fragment in the first place). Note there is no API impact of removing this.
Comment 1 John Arthorne CLA 2011-02-02 14:02:51 EST
Created attachment 188179 [details]
Fix against R4_HEAD

Andrew, when is a good time to run a 4.1 test build?
Comment 2 John Arthorne CLA 2011-03-15 13:37:37 EDT
I have released and tagged this change.
Comment 3 Steffen Pingel CLA 2011-09-16 06:01:09 EDT
I just extracted eclipse-SDK-4.2M1-linux-gtk-x86_64.tar.gz and I see this version:

$ ls eclipse/plugins/org.eclipse.core.runtime.compatibility.auth*
eclipse/plugins/org.eclipse.core.runtime.compatibility.auth_3.2.200.v20110110.jar
eclipse/plugins/org.eclipse.core.runtime.compatibility.auth.source_3.2.200.v20110110.jar

It appears to be included in org.eclipse.rcp_4.1.0.v20110303-92CWFqiFmC9z-qgz-Z7HZvARhVIl/feature.xml. 

According to this bug I would not expect that bundle to be present? This came up on bug 357205 where a user reported that they didn't have this bundle in their e4 I-build.
Comment 4 John Arthorne CLA 2011-09-16 09:46:41 EDT
It is not included in any of our features, but I also see the bundle in my install. I'll take a look. This might be due to p2 helpfully adding it because it satisfies an optional dependency.
Comment 5 DJ Houghton CLA 2011-09-23 09:36:10 EDT
It appears in the 4.2M1 build but is gone again in the 4.2M2 build. I'll check to see if any dependencies were changed.
Comment 6 DJ Houghton CLA 2011-09-23 11:09:57 EDT
The RCP feature was updated the map file was pointing to the wrong version. I believe it is still wrong for the 4.x stream but is ok for HEAD because of a recent change. 

The map file is in CVS here:

 /cvsroot/eclipse/e4/releng/org.eclipse.e4.sdk
Comment 7 DJ Houghton CLA 2011-09-23 11:12:07 EDT
Actually it is ok in the 4.x maintenance branch now, because of a change Andrew did on Aug 26. 
I believe this can be closed again.
Comment 8 David Williams CLA 2012-11-06 16:54:23 EST
I still see this plugin listed on core.map in our master version of maps, in a sections commented as: 

!**** Legacy Runtime
plugin@org.eclipse.core.boot=GIT,tag=v20120523-2004,repo=git://git.eclipse.org/gitroot/platform/eclipse.platform.runtime.git,path=bundles/org.eclipse.core.boot
plugin@org.eclipse.core.runtime.compatibility=GIT,tag=v20120521-2346,repo=git://git.eclipse.org/gitroot/platform/eclipse.platform.runtime.git,path=bundles/org.eclipse.core.runtime.compatibility
plugin@org.eclipse.core.runtime.compatibility.auth=GIT,tag=v20120523-2004,repo=git://git.eclipse.org/gitroot/platform/eclipse.platform.runtime.git,path=bundles/org.eclipse.core.runtime.compatibility.auth
fragment@org.eclipse.core.runtime.compatibility.registry=GIT,tag=v20120912-175931,repo=git://git.eclipse.org/gitroot/platform/eclipse.platform.runtime.git,path=bundles/org.eclipse.core.runtime.compatibility.registry

Just for clarity, I assume at least the 
org.eclipse.core.runtime.compatibility.auth
plugin no longer needs to be listed in the map?
Comment 9 David Williams CLA 2012-11-06 17:48:49 EST
Just to cross reference, I noticed this in map files while hunting down why this bundle was showing up in juno common repository. The reason is unrelated to the map entry ... I opened bug 393722 for Mylyn.
Comment 10 Thomas Watson CLA 2012-11-06 22:43:45 EST
(In reply to comment #8)
> Just for clarity, I assume at least the 
> org.eclipse.core.runtime.compatibility.auth
> plugin no longer needs to be listed in the map?

I think you are right for the map files used for the 4.x builds.