Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 336079 - "Show Line Numbers" in compare editor context menu should be checked initially
Summary: "Show Line Numbers" in compare editor context menu should be checked initially
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Compare (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows 7
: P3 normal with 2 votes (vote)
Target Milestone: 4.6 M5   Edit
Assignee: Tobias Melcher CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-02 10:41 EST by Markus Keller CLA
Modified: 2015-12-24 21:27 EST (History)
5 users (show)

See Also:

Attachments
Screenshot showing the wrong checked state (48.85 KB, image/png)
2015-01-16 10:52 EST, Thomas Schulze zur Wiesch CLA 		no flags Details
patch (2.25 KB, application/octet-stream)
2015-01-17 07:17 EST, Tobias Melcher CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2011-02-02 10:41:06 EST 
I20110201-0800

Show line numbers in the text editor. Open a compare editor.
=> "Show Line Numbers" in compare editor context menu should now be checked initially, but it's not.

Has probably been broken with bug 266089.
Comment 1 Thomas Schulze zur Wiesch CLA 2015-01-16 10:51:39 EST 
Issue still exists in Eclipse 4.4 and 4.5. Any update on this?

Reproduce: enable "Show line numbers" in preferences, open compare editor for a source (e.g. local history), line numbers are shown, right-click in one of the editors -> Bug: menu entry "Show line numbers" is not checked

Best regards,
Thomas
Comment 2 Thomas Schulze zur Wiesch CLA 2015-01-16 10:52:26 EST 
Created attachment 250000 [details]
Screenshot showing the wrong checked state
Comment 3 Tobias Melcher CLA 2015-01-17 07:17:58 EST 
Created attachment 250011 [details]
patch

Sorry, I cannot upload the change to gerrit. I used following git url https://git.eclipse.org/r/platform/eclipse.platform.team.git. Is this not the correct one? I always get message "not authorized" when trying to push to gerrit.
Comment 4 Tobias Melcher CLA 2015-01-17 07:34:34 EST 
got it now. 

see https://git.eclipse.org/r/#/c/39809/
Comment 5 Matthias Becker CLA 2015-02-18 02:33:30 EST 
What's the status of this bug / patch? Will it go into the next Mars milestone?
Comment 7 Sergey Prigogin CLA 2015-12-24 21:26:46 EST 
Thank you, Tobias, for the fix.