Description Klaus S. 2011-02-02 10:07:51 EST

Build Identifier: 

Currently the DiagramEditor accepts as input "DiagramEditorInput" and "IFileEditorInput". It might be useful to enable the DiagramEditor accepting an URIEditorInput which enables open diagram files which are located outside the current workspace. "IFileEditorInput" cannot handle files which are not inside the current workspace (unless the file is linked into the workspace).

Suggestion: adding the following easy snipped into DiagramEditorFactory.createEditorInput(IEditorInput otherInput) which creates the DiagramEditorInput from a URIEditorInput

if (otherInput instanceof URIEditorInput){
final URIEditorInput fileInput = (URIEditorInput) otherInput;
final TransactionalEditingDomain domain = createResourceSetAndEditingDomain();
URI diagramFileUri = fileInput.getURI();
if (diagramFileUri != null) {
// the file has to contain one base node which has to be a diagram
diagramFileUri = GraphitiUiInternal.getEmfService().mapDiagramFileUriToDiagramUri(diagramFileUri);
return new DiagramEditorInput(diagramFileUri, domain, null, true);
}
}

Reproducible: Always