Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 336054 - Combo eats text on Enter
Summary: Combo eats text on Enter
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: SWT (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows All
: P3 normal (vote)
Target Milestone: 4.4 M3   Edit
Assignee: Niraj Modi CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-02 06:21 EST by Markus Keller CLA
Modified: 2013-10-08 14:42 EDT (History)
4 users (show)

See Also:

Attachments
This patch fixes the Bug 336054 - Combo eats text on Enter (930 bytes, patch)
2013-09-26 07:35 EDT, Niraj Modi CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2011-02-02 06:21:44 EST 
I20110201-0800, same on WinXP and Win 7

- Control Example > Combo
- click the Combo's dropdown arrow
- type ABC
- press Enter key
=> the text I just entered is eaten (text field is cleared)
=> expected: text stays, but drop-down is closed

This only seems to happen if at the time the drop-down is opened, the text field contains an entry from the combo list.

Happened to me in the File Search dialog in the "File name patterns" field.
Comment 1 Niraj Modi CLA 2013-09-26 07:35:09 EDT 
Created attachment 235842 [details]
This patch fixes the Bug 336054 - Combo eats text on Enter

Hi Silenio/Bogdan,
Potential Patch: For your review.
Comment 2 Bogdan Gheorghe CLA 2013-10-08 14:42:43 EDT 
Patch was good Niraj. Just one small change was needed: added a check to only do the work if it is not a READONLY combo. 

Patch released to master.

http://git.eclipse.org/c/platform/eclipse.platform.swt.git/commit/?id=3d7660d12b57efbf49e0dce8bf932fcbbf327686