336007 – [server] Entries in log from gitfs.. Already-up-to-date

Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 336007 - [server] Entries in log from gitfs.. Already-up-to-date

Summary: [server] Entries in log from gitfs.. Already-up-to-date

Status:	RESOLVED FIXED

Alias:	None

Product:	Orion
Classification:	ECD
Component:	Client (show other bugs)
Version:	0.2
Hardware:	PC Windows 7

Importance:	P3 normal (vote)
Target Milestone:	0.2
Assignee:	Tomasz Zarna
QA Contact:

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-02-01 14:14 EST by John Arthorne
Modified:	2011-09-01 11:41 EDT (History)
CC List:	0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description John Arthorne

2011-02-01 14:14:07 EST

Orion M5

When I look at the server log on orion.eclipse.org, it is filled with entries like the following. This is not an error and shouldn't be written to the log. 

!ENTRY org.eclipse.filesystem.git 1 1 2011-01-31 14:00:43.714
!MESSAGE Pull (fetch/merge) result /Already-up-to-date for gitfs:/git:%5C%5Cgithub.com%5Cbokowski%5Ce4rover.git?%5C%5Corg.eclipse
con.e4rover.client%5Cicons%5Cpilcrow.png

Comment 1 Tomasz Zarna

2011-02-02 04:55:02 EST

This is not an error indeed, it's an info message logged in org.eclipse.orion.server.filesystem.git.GitFileStore.pull() with IStatus.INFO severity. I've set "eclipse.log.level" system property to WARNING in all launch configurations. I guess this will be controlled by a logback configuration eventually.

Comment 2 John Arthorne

2011-02-02 09:51:35 EST

(In reply to comment #1)
> I've set "eclipse.log.level" system property to WARNING in all launch
> configurations. I guess this will be controlled by a logback configuration
> eventually.

The main problem case is on orion.eclipse.org, which doesn't use a launch configuration. Why do you even need to log an INFO about this?

Comment 3 Tomasz Zarna

2011-02-02 10:22:17 EST

I see, well I'm saving it for a case when the pull did actually take place and a merge was done. However, I don't have any strong feelings about it, so feel free to remove it (or comment out). I still think that a log configuration filtering out such entries would be an apt choice.

Comment 4 John Arthorne

2011-02-07 11:20:32 EST

I have converted this to a Log4j call. It is now disabled by default but can be enabled by uncommenting this line in logback.xml:

  <!-- <logger name="org.eclipse.orion.server.filesystem.git.GitFileStore" level="INFO"/> -->

Comment 5 Tomasz Zarna

2011-02-08 04:51:26 EST

Thanks John. Should I now remove the eclipse.log.level property from launch configurations (comment 1) or leave it just in case? 

btw, you made fixing bug 335474 so easy with the conversion to Log4j, thanks.

Comment 6 John Arthorne

2011-02-08 09:39:03 EST

(In reply to comment #5)
> Thanks John. Should I now remove the eclipse.log.level property from launch
> configurations (comment 1) or leave it just in case? 

Probably better to remove it, just in case it hides a message that is useful to someone.

Comment 7 Tomasz Zarna

2011-02-08 10:22:26 EST

Good point, it's removed and the change has been pushed to master.