Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 335921 - Valid facets for int type include fractionDigits
Summary: Valid facets for int type include fractionDigits
Status: CLOSED WORKSFORME
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: WTP Incubator (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Stanislav Nichev CLA
QA Contact: Dimitar Tenev CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-02-01 00:26 EST by Noopur Gupta CLA
Modified: 2021-11-18 16:19 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Noopur Gupta CLA 2011-02-01 00:26:47 EST 
Hello,

The isTotalDigitsFacetSupported(org.eclipse.xsd.XSDSimpleTypeDefinition) method of org.eclipse.wst.sse.sieditor.model.utils.SimpleTypeFacetsUtils class returns true for the rootType int but the return value should be false. 
The valid facets for int returned by the Eclipse EMF model also include totalDigits and fractionDigits which are not supported for int type.

Thanks,
Noopur Gupta
Comment 1 Stanislav Nichev CLA 2011-02-21 09:16:32 EST 
Hi Noopur,

The XSDSimpleTypeDefinition#getValidFacets() method returns the list: [totalDigits, fractionDigits, pattern, whiteSpace, enumeration, maxInclusive, maxExclusive, minInclusive, minExclusive].

We are currently checking if the valid facets list contains the XSDConstants.TOTALDIGITS_ELEMENT_TAG facet.

According to the XML Schema specification (http://www.w3.org/TR/xmlschema-2/#int), the fractionDigits facet is allowed, but it's value is restricted to 0. "int" is the derived type of "long" which is the derived type of "integer". The restriction on the fractionDigits is described in http://www.w3.org/TR/xmlschema-2/#integer.

If you try to change the value of the fractionDigits facets, a live validation message is shown on the UI control - to show the described restriction.

I'm currently unable to find a restrinction on the totalDigits facet. Could you please point me to such a restriction in the XML Schema specification?

Since the user can edit the value of the fractionDigits facet through the source, we need to show it in the UI part.

Regards,
Stanislav
Comment 2 Stanislav Nichev CLA 2011-06-05 15:00:56 EDT 
Hi Colleagues,

I'm updating the status of this bugzilla since the current one (resolved/invalid) is not correct.
The status should have been closed/worksforme.

Regards,
Stanislav