Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 335877 - [ActivityMgmt] [QuickAccess] Disabled/filtered contributions are available in the Quick Access dialog
Summary: [ActivityMgmt] [QuickAccess] Disabled/filtered contributions are available in...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.6.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7 M6   Edit
Assignee: Remy Suen CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-31 12:10 EST by Matthias Striegl CLA
Modified: 2011-03-08 09:50 EST (History)
3 users (show)

See Also:


Attachments
QuickAccess patch v1 (8.08 KB, patch)
2011-01-31 13:47 EST, Remy Suen CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Striegl CLA 2011-01-31 12:10:45 EST
Build Identifier: 20100917-0705

It looks like the Quick Access dialog (Ctrl+3) does not bother (all) contributions which are otherwise disabled using the org.eclipse.ui.activities extension point. Tried with "Cheat Sheets" view part and the "General/Perspectives" preference page. The view correctly disappeared from the "Show View" dialog and the preferences page disappeared correctly from the Preferences dialog (General->Perspectives), but both could still to be found in the Quick Access dialog (opened by Ctrl+3). Even worse, the view could also be openened that way (the perspective page not).

Reproducible: Always

Steps to Reproduce:
1. Contribute to org.eclipse.ui.activities:
   <extension
         point="org.eclipse.ui.activities">
      <activity
            description="Filtered items still appear in Quick Access"
            id="my.disabled.ones"
            name="Disabling some contributions">
      </activity>
      <activityPatternBinding
            activityId="my.disabled.ones"
            isEqualityPattern="true"
            pattern="org.eclipse.ui.ide/org.eclipse.ui.preferencePages.Perspectives">
      </activityPatternBinding>
      <activityPatternBinding
            activityId="my.disabled.ones"
            isEqualityPattern="true"
            pattern="org.eclipse.ui.cheatsheets/org.eclipse.ui.cheatsheets.views.CheatSheetView">
      </activityPatternBinding>
   </extension>
2. Launch as Eclipse Application using a launch config that includes the plugins org.eclipse.ui.workbench, org.eclipse.ui.cheatsheets (plus required ones)
3. Open the Quick Access dialog by pressing Ctrl+3
4. Enter "Cheat" -> "Cheat Sheet - Help" view appears within the Views section and can be opened
5. Enter "Perspe" -> "Perspectives General" preference page appears in the Preferences section (though selecting it just opens the Preferences dialog, but not the page)
Comment 1 Remy Suen CLA 2011-01-31 13:47:24 EST
Created attachment 187989 [details]
QuickAccess patch v1

Patch to honour activities for perspectives, preferences, views, and wizards.
Comment 2 Remy Suen CLA 2011-01-31 14:38:16 EST
(In reply to comment #1)
> Created attachment 187989 [details]
> QuickAccess patch v1

Patch released to CVS HEAD. Thanks for the bug report!
Comment 3 Remy Suen CLA 2011-03-08 09:50:41 EST
Verified with an inner on Windows XP with I20110307-2110.