Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 335803 - RecoveringCDOSessionConfiguratioImpl lacks sane defaults
Summary: RecoveringCDOSessionConfiguratioImpl lacks sane defaults
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.core (show other bugs)
Version: 4.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Caspar D. CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-30 23:04 EST by Caspar D. CLA
Modified: 2011-06-23 03:40 EDT (History)
2 users (show)

See Also:
stepper: review+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Caspar D. CLA 2011-01-30 23:04:53 EST 
Fiels heartBeatPeriod, heartBeatTimeout, connectorTimeout,
are not initialized, and so when such a session config
is used to instantiate a session, this session ends up
have '0' values for its corresponding config params.
Comment 1 Caspar D. CLA 2011-01-30 23:05:40 EST 
### Eclipse Workspace Patch 1.0
#P org.eclipse.emf.cdo.net4j
Index: src/org/eclipse/emf/cdo/internal/net4j/RecoveringCDOSessionConfigurationImpl.java
===================================================================
--- src/org/eclipse/emf/cdo/internal/net4j/RecoveringCDOSessionConfigurationImpl.java	(revision 6981)
+++ src/org/eclipse/emf/cdo/internal/net4j/RecoveringCDOSessionConfigurationImpl.java	(working copy)
@@ -24,13 +24,13 @@
 {
   private IManagedContainer container;
 
-  private boolean heartBeatEnabled;
+  private boolean heartBeatEnabled = false;
 
-  private long heartBeatPeriod;
+  private long heartBeatPeriod = 1000L;
 
-  private long heartBeatTimeout;
+  private long heartBeatTimeout = 5000L;
 
-  private long connectorTimeout;
+  private long connectorTimeout = 10000L;
 
   public RecoveringCDOSessionConfigurationImpl(IManagedContainer container)
   {
Comment 2 Caspar D. CLA 2011-02-03 04:31:13 EST 
Committed to trunk, rev. 7010
Comment 3 Eike Stepper CLA 2011-06-23 03:40:21 EDT 
Available in R20110608-1407