Community
Participate
Working Groups
Created attachment 187920 [details] org.eclipse.ecf.docshare.cdt I followed the instructions from: http://wiki.eclipse.org/Extending_Real-Time_Shared_Editing_for_Use_with_Other_Editors on creating a new plugin to be used with CDT files, then added the following markup to plugin.xml <extension point="org.eclipse.ui.menus"> <menuContribution locationURI="popup:#CEditorContext"> <dynamic class="org.eclipse.ecf.docshare.menu.DocShareRosterMenuContributionItem" id="org.eclipse.ecf.editorshare.ceditor"> </dynamic> </menuContribution> </extension> I packed the plugin as a .jar, copied it to the eclipse/plugins folder, started Eclipse, but the Share Resource to Collaboration menu still does not appear for .c/.cpp files (for java files it does). Am I missing something or we have a bug somewhere? Liviu Ionescu
I expect that this is probably a duplicate of releng bug 335787. Can you confirm that you are using the xmpp provider? The docshare application depends upon the datashare and sharedobject apis (and the xmpp provider needs the implementation of these APIs also). What happened with 335787 is that the xmpp provider was broken into two new fragments, and these fragments did not get into the features for the xmpp provider...effectively removing cola/docshare from the distribution. This will be corrected in ECF 3.5, but we can't correct it for 3.4. If you are not using the xmpp provider please let know on this bug, as it could be something else.
(In reply to comment #1) > I expect that this is probably a duplicate of releng bug 335787. can you update the number of this releng bug? since 335787 is the current bug. > Can you > confirm that you are using the xmpp provider? initially I tries XMPP, but later I tried MSN, with no success. > If you are not using the xmpp provider please let know on this bug, as it could > be something else. if you can recommend any other provider/configuration tests, I would be more than happy to help. Liviu
(In reply to comment #2) > (In reply to comment #1) > > I expect that this is probably a duplicate of releng bug 335787. > > can you update the number of this releng bug? since 335787 is the current bug. > > > Can you > > confirm that you are using the xmpp provider? Given your information below, I'm going to mark this bug as a duplicate of 333041. > > initially I tries XMPP, but later I tried MSN, with no success. The MSN provider currently doesn't support the datashare or the sharedobject API...so MSN provider doesn't support docshare. > > > If you are not using the xmpp provider please let know on this bug, as it could > > be something else. > > if you can recommend any other provider/configuration tests, I would be more > than happy to help. Do mean help with dealing with releng bug 333041? Or do you mean helping with the MSN provider? Although I'm not really familiar with the MSN provider's internals (it was originally done by Remy Suen, another ECF committer), it may be possible to add support for shared object API (and with that in place, the MSN provider would be able to reuse the org.eclipse.ecf.provider.datashare implementation...and then docshare would work with the MSN provider). In any case, if you have the desire and resources, it would be great to open a new enhancement request for the MSN provider...to support datashare...so that it could be used with the docshare application. And if you are able to contribute to the implementation that would be great...as unfortunately I personally do not have the resources to take on such an enhancement. > > Liviu *** This bug has been marked as a duplicate of bug 333041 ***
> Do mean help with dealing with releng bug 333041? I mean finding a functional solution for enabling shared editing of c/c++ files, with any provider. can you suggest something to try? > Or do you mean helping with the MSN provider? not necessarily, as a Mac guy, the MSN provider would not be the first choice. my first choice would be the Skype provider, but I noticed it is not yet ready for Mac. do you know the status of Skype for Windows? does it support shared editing? BTW, I'm a bit confused where the problem is. if the XMPP provider is broken, why it affects only CDT editing and Java and text editing works just fine? Liviu
(In reply to comment #4) > I mean finding a functional solution for enabling shared editing of c/c++ > files, with any provider. xmpp would be the my first choice. > > can you suggest something to try? > > > Or do you mean helping with the MSN provider? > > not necessarily, as a Mac guy, the MSN provider would not be the first choice. > > my first choice would be the Skype provider, but I noticed it is not yet ready > for Mac. > > do you know the status of Skype for Windows? does it support shared editing? It does, but we have not been building or testing the Skype for Windows provider...and so I'm not sure what it's status is (especially since Skype itself has moved through several versions). BTW, the Skype provider code is now located here: https://github.com/ECF/Skype > > BTW, I'm a bit confused where the problem is. if the XMPP provider is broken, > why it affects only CDT editing and Java and text editing works just fine? My mistake. I'm reopening this bug. I missed your statement in the initial report that it was working OK for the java editor...and if shared editing is working OK for the java editor, it should work for the C/C++ editor. Returning to your initial report: <extension point="org.eclipse.ui.menus"> <menuContribution locationURI="popup:#CEditorContext"> <dynamic class="org.eclipse.ecf.docshare.menu.DocShareRosterMenuContributionItem" id="org.eclipse.ecf.editorshare.ceditor"> </dynamic> </menuContribution> </extension> My initial thought is this: Is it possible that the #CEditorContext has somehow changed in a recent version of the C/C++ editor? (I'm assuming that you had previously had docshare working on some earlier version of C/C++ editor). So first I would suggest verifying that the #CEditorContext is right. If you verify that that is right, I would suggest that you try to run things in a debugger and verify that the C/C++ editor right button click is getting into/reaching a break point in org.eclipse.ecf.docshare.menu.DocShareRosterMenuContributionItem. > > Liviu
As bug 333041 has now been resolved, would you please retry the CDT docshare extension described in this bug? It's very possible that even with 333041 fixed that this will *not* work (e.g. because something has changed about the CDT editor, for example...making it incompatible with the docshare extension...or some new problem in the locationURI or some such), but it would still be valuable to try out a recent build...available here: https://build.ecf-project.org/jenkins/job/C-HEAD-sdk.feature/ under 'Last successful artifacts' link.
Created attachment 207163 [details] CDT DocShare Support Bundle >> I packed the plugin as a .jar, copied it to the eclipse/plugins folder, started >> Eclipse, but the Share Resource to Collaboration menu still does not appear for >> .c/.cpp files (for java files it does). I create my own bundle for CDT as wiki says. And it`s works for me. I attached it to post, please try it.
(In reply to comment #7) > Created attachment 207163 [details] > CDT DocShare Support Bundle > > >> I packed the plugin as a .jar, copied it to the eclipse/plugins folder, started > >> Eclipse, but the Share Resource to Collaboration menu still does not appear for > >> .c/.cpp files (for java files it does). > > I create my own bundle for CDT as wiki says. And it`s works for me. I attached > it to post, please try it. Thanks for doing this testing...it's good to hear that it's working for you. My expectation is that fixing bug 333041 fixed this bug as well....so I'm closing this bug. I think it would be great if CDT were to include your bundle in CDT itself...perhaps opening up an enhancement request (for CDT) would be a good thing to do. If you do so, please include me (slewis at composent.com) on the new enhancement request. Thanks again for the ECF usage and testing. *** This bug has been marked as a duplicate of bug 333041 ***
