Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 335778 - [quick assist] 'Pull Negation up' and 'Push Negation down' unnecessarily available
Summary: [quick assist] 'Pull Negation up' and 'Push Negation down' unnecessarily avai...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7 M6   Edit
Assignee: Deepak Azad CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-29 14:33 EST by Deepak Azad CLA
Modified: 2011-03-07 12:18 EST (History)
2 users (show)

See Also:

Attachments
fix+tests (7.61 KB, patch)
2011-02-21 06:25 EST, Deepak Azad CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Deepak Azad CLA 2011-01-29 14:33:23 EST 
3.7 M5

------------------------------------------------------------
package snippet;

public class Snippet {
	void foo(Object a) {
		if (!(a instanceof String)) {

		}
	}
}
------------------------------------------------------------

- Select "!(a instanceof String)"
- Ctrl+1
- 'Pull Negation up' and 'Pull Negation down' are available, but they do not really do anything here...
Comment 1 Markus Keller CLA 2011-02-03 10:13:57 EST 
Should also not show up for simpler cases like:

        if (!b) { }
Comment 2 Deepak Azad CLA 2011-02-21 06:25:59 EST 
Created attachment 189399 [details]
fix+tests
Comment 3 Deepak Azad CLA 2011-02-21 06:26:21 EST 
Fixed in HEAD.
Comment 4 Raksha Vasisht CLA 2011-03-07 12:18:52 EST 
Verified for 3.6 M6.