Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 335741 - Ensure that existing validation is added to Errors/Warnings preferences
Summary: Ensure that existing validation is added to Errors/Warnings preferences
Status: RESOLVED FIXED
Alias: None
Product: Dali JPA Tools
Classification: WebTools
Component: General (show other bugs)
Version: 3.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.0 M7   Edit
Assignee: Nan Li CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-28 17:03 EST by Neil Hauge CLA
Modified: 2011-04-26 17:37 EDT (History)
0 users

See Also:
neil.hauge: review+

Attachments
Proposed Patch (244.80 KB, patch)
2011-04-12 11:02 EDT, Nan Li CLA 		no flags Details | Diff
Proposed Patch (248.14 KB, patch)
2011-04-26 10:00 EDT, Nan Li CLA 		neil.hauge: iplog+
Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Neil Hauge CLA 2011-01-28 17:03:43 EST 
We need to make sure that all of our existing validation and all newly added validation is included in the Errors/Warning prefs.
Comment 1 Neil Hauge CLA 2011-04-04 12:22:18 EDT 
Currently we don't support Errors/Warnings prefs for EclipseLink warnings, so this will not be in the scope of this bug.
Comment 2 Nan Li CLA 2011-04-12 11:02:28 EDT 
Created attachment 193055 [details]
Proposed Patch

1. Each newly added entires was commented with "3.0 M7" in JpaProblemSeveritiesPage.java and JptUiValidationPreferenceMessages.java to facilitate patch review. After review is done, all the "3.0 M7" will be removed and a new patch will be created.

2. Please make sure the accuracy of the messages of the newly added entries since these messages are modified to fit in the preference page.

2. Moved VIRTUAL_SECONDARY_TABLE_PRIMARY_KEY_JOIN_COLUMN_* from Table category to Column -> Implied Attributes category. Please make sure it's correct.
Comment 3 Neil Hauge CLA 2011-04-25 17:33:04 EDT 
This patch has fallen out of date and needs to be updated to compile.
Comment 4 Nan Li CLA 2011-04-26 10:00:15 EDT 
Created attachment 194051 [details]
Proposed Patch

Included the recently added messages
Comment 5 Neil Hauge CLA 2011-04-26 17:05:41 EDT 
Patch committed to head.