Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 335738 - Jars main class in manifest not deploying properly inside WARs
Summary: Jars main class in manifest not deploying properly inside WARs
Status: RESOLVED FIXED
Alias: None
Product: WTP Java EE Tools
Classification: WebTools
Component: jst.j2ee (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows Server 2003
: P3 normal (vote)
Target Milestone: 3.2.3   Edit
Assignee: Carl Anderson CLA
QA Contact: Chuck Bridgham CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-28 16:47 EST by Jason Sholl CLA
Modified: 2011-02-09 01:59 EST (History)
3 users (show)

See Also:
david_williams: pmc_approved+
raghunathan.srinivasan: pmc_approved+
ccc: pmc_approved? (naci.dai)
deboer: pmc_approved+
ccc: pmc_approved? (neil.hauge)
ccc: pmc_approved? (kaloyan)
cbridgha: review+

Attachments
Patch for 3.2.3 (1.65 KB, patch)
2011-01-28 16:49 EST, Jason Sholl CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Sholl CLA 2011-01-28 16:47:38 EST 
This is follow on work for bug 334156 to ensure that no jars are ever treated as application clients if they are being deployed inside WARs.
Comment 1 Jason Sholl CLA 2011-01-28 16:49:17 EST 
Created attachment 187886 [details]
Patch for 3.2.3
Comment 2 Chuck Bridgham CLA 2011-02-04 12:00:15 EST 
approve for PMC review
Comment 3 Carl Anderson CLA 2011-02-04 13:17:05 EST 
* Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 

This was encountered by a customer, and it prevents proper deployment of non-single-root WARs with Application Clients mapped to WEB-INF/lib.  Currently, our code treats application clients in WEB-INF/lib as application clients (which causes further deployment to be attempted).

* Is there a work-around? If so, why do you believe the work-around is insufficient?

There is no workaround within WTP.  The user can go to the server and modify the deployment, but that is not a viable workaround.

* How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added?

This has been tested by hand, and the Java EE JUnit bucket has been run against it.

* Give a brief technical overview. Who has reviewed this fix? 

Carl Anderson and Chuck Bridgham have reviewed this fix.  The fix is to treat JARs in a WAR's WEB-INF/lib as JARs, instead of attempting to treat them as specific module types and do further deployment.

* What is the risk associated with this fix?

This is a relatively low risk - only application clients packaged in WEB-INF/lib are affected.
Comment 4 Carl Anderson CLA 2011-02-09 01:16:37 EST 
Committed to R3_2_maintenance for WTP 3.2.3 RC3