Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 335733 - org.eclipse.e4.ui.workbench.addons.swt has dependency on org.eclipse.ui
Summary: org.eclipse.e4.ui.workbench.addons.swt has dependency on org.eclipse.ui
Status: VERIFIED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 4.1 M7   Edit
Assignee: Remy Suen CLA
QA Contact: Eric Moffatt CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 342947
  Show dependency tree
 
Reported: 2011-01-28 14:54 EST by Thomas Schindl CLA
Modified: 2011-04-29 13:58 EDT (History)
2 users (show)

See Also:

Attachments
org.eclipse.e4.ui.workbench.addons.swt split patch v1 (67.60 KB, patch)
2011-04-19 12:46 EDT, Remy Suen CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Schindl CLA 2011-01-28 14:54:37 EST 
This means when one wants to use it one has to get in the compat layer:
* minmax: Can be fixed quite easily because it only uses some ID stuff from 
          IPageLayout and one WorkbenchImages-call

  => Proposal fix them and leave it in e4.ui.workbench.addons.swt

* perspectiveswitcher: Looks like this is harder to fix because it usies all 
                       sorts of Workbench-Classes

  => Proposal move it to compat layer
Comment 1 Remy Suen CLA 2011-04-19 10:46:57 EDT 
We use new_persp.gif for the minimized shared area at the moment. This seems wrong considering we're not making any new perspectives when the user clicks on it. The 3.x icon had a pencil in it but that doesn't seem like it applies to 4.x anymore since we now support having other parts in the shared area (besides just editors).
Comment 2 Remy Suen CLA 2011-04-19 12:46:01 EDT 
Created attachment 193599 [details]
org.eclipse.e4.ui.workbench.addons.swt split patch v1

Patch with all the textual changes not including the image files that had to be copied over from org.eclipse.ui.
Comment 3 Remy Suen CLA 2011-04-19 12:49:06 EDT 
(In reply to comment #2)
> Created attachment 193599 [details]
> org.eclipse.e4.ui.workbench.addons.swt split patch v1

Patch (and icons) released to CVS HEAD. Also updated the build.properties file (which was not in the patch) so that the 'icons/' folder would be included.
Comment 4 Remy Suen CLA 2011-04-29 13:58:32 EDT 
Verified by source inspection with I20110429-0945.