Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 335724 - Regression: Changes to AbstractSession cause test failure
Summary: Regression: Changes to AbstractSession cause test failure
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Eclipselink (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Guy Pelletier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-28 13:27 EST by Guy Pelletier CLA
Modified: 2022-06-09 10:08 EDT (History)
1 user (show)

See Also:

Attachments
Modifying test to pass on MySQL (1.49 KB, patch)
2011-01-28 13:34 EST, Guy Pelletier CLA 		no flags Details | Diff
Proposed changes (1.92 KB, patch)
2011-01-28 14:01 EST, Guy Pelletier CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Guy Pelletier CLA 2011-01-28 13:27:03 EST 
org.eclipse.persistence.testing.tests.validation.BatchCommitTransactionExceptionTest started failing after revision 8888.

The changes to Abstract session were as follows (line 529)

// Ensure the transaction is rolledback on failure to commit.
try {
  accessor.rollbackTransaction(this);
} catch (Exception ingore) {}

If I removed this change, the test passes.
Comment 1 Guy Pelletier CLA 2011-01-28 13:34:14 EST 
Created attachment 187861 [details]
Modifying test to pass on MySQL

MySql has been removed from the valid list of platforms for this test. Once this bug is corrected it will need to be re-added.
Comment 2 Guy Pelletier CLA 2011-01-28 14:01:16 EST 
Created attachment 187865 [details]
Proposed changes

After a discussion with Andrei who reviewed the original transaction, it would apprear the offending block of code was intended to be removed and was committed by mistake. This patch removes that code and re-enables the test on MySQL.
Comment 3 Guy Pelletier CLA 2011-01-28 14:03:32 EST 
Changes have been submitted.

Reviewed: Andrei Ilitchev

Tests: BatchCommitTransactionExceptionTest.java now passes on MySQL platform.
Comment 4 Eclipse Webmaster CLA 2022-06-09 10:08:58 EDT 
The Eclipselink project has moved to Github: https://github.com/eclipse-ee4j/eclipselink