Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 335713 - [server] GitFileStore.canPush() check can be omitted
Summary: [server] GitFileStore.canPush() check can be omitted
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Tomasz Zarna CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 334094
  Show dependency tree
 
Reported: 2011-01-28 12:48 EST by Tomasz Zarna CLA
Modified: 2011-09-01 11:41 EDT (History)
0 users

See Also:

Attachments
Fix v01 (1.91 KB, patch)
2011-02-01 09:30 EST, Tomasz Zarna CLA 		no flags Details | Diff
mylyn/context/zip (4.21 KB, application/octet-stream)
2011-02-01 09:30 EST, Tomasz Zarna CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Zarna CLA 2011-01-28 12:48:51 EST 
Similarly to Utils.isValidRemote from bug 335705, org.eclipse.orion.server.filesystem.git.GitFileStore.canPush() doesn't have to be called each time before doing a push. Instead, we could gracefully handle an eventual exception thrown when doing the push. This should save us some time when pushing to a valid/"pushable" repository.
Comment 1 Tomasz Zarna CLA 2011-02-01 09:30:44 EST 
Created attachment 188046 [details]
Fix v01

This fix won't give much boost when working with local repositories. However, for remote repos the improvement should be visible.
Comment 2 Tomasz Zarna CLA 2011-02-01 09:30:46 EST 
Created attachment 188047 [details]
mylyn/context/zip
Comment 3 Tomasz Zarna CLA 2011-02-01 09:31:44 EST 
(In reply to comment #1)
> [...] the improvement should be visible.

Especially when combined with bug 335705.
Comment 4 Tomasz Zarna CLA 2011-02-03 10:50:29 EST 
Fixed with 6bfbdf3b7b378e68aacbf687af7e961d370f6835.