Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 335712 - org.eclipse.xtext.ui.shared.internal.Activator stop could be robust against start failures
Summary: org.eclipse.xtext.ui.shared.internal.Activator stop could be robust against s...
Status: CLOSED FIXED
Alias: None
Product: TMF
Classification: Modeling
Component: Xtext (show other bugs)
Version: 1.0.0   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: M4   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-28 12:38 EST by Tim Moore CLA
Modified: 2017-10-31 11:31 EDT (History)
0 users

See Also:
sven.efftinge: kepler+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Moore CLA 2011-01-28 12:38:41 EST 
A bug in our code caused a Guice provision error in org.eclipse.xtext.ui.shared.internal.Activator#start(...). The result was that the resourceChangeListener field wasn't initialized. On bundle stop() this causes an AssertionFailedException to be thrown from ResourceChangeListenerList.

Now, given the large number of errors that were logged due to the injection failure this does seem slightly trivial, but it would be easy to guard against the exception on stop - and every little helps, right? :)
Comment 1 Sven Efftinge CLA 2012-11-20 12:16:44 EST 
pushed to masetr
Comment 2 Eclipse Webmaster CLA 2017-10-31 11:31:17 EDT 
Requested via bug 522520.

-M.