Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 335706 - [client] Incremental find traps cursor
Summary: [client] Incremental find traps cursor
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Editor (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 minor (vote)
Target Milestone: 0.3 RC1   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-28 12:06 EST by Mark Macdonald CLA
Modified: 2011-10-11 15:40 EDT (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Macdonald CLA 2011-01-28 12:06:11 EST
1. Open the editor and put the editing caret somewhere in the middle of the file.
2. Press Ctrl+J. You see "Incremental find:" on the statusbar.
3. Press the Up arrow key.
4. The cursor moves backwards by 1 character, and incremental find mode is still active. 

I expected the cursor to move up a line, and incremental find to be canceled.

Strangely, it's only the Up arrow that has this issue -- the other directional keys work as expected.
Comment 1 Felipe Heidrich CLA 2011-01-28 14:52:52 EST
I think at some point using arrow up and arrow down in the incremental find would move to next and previous occurance in the search set. Later this behaviour was removed.
Comment 2 Mark Macdonald CLA 2011-09-27 14:26:55 EDT
(In reply to comment #1)
> I think at some point using arrow up and arrow down in the incremental find
> would move to next and previous occurance in the search set. Later this
> behaviour was removed.

That feature still exists and works OK when you have search hits. The bug here is the inconsistency when there no hits: lineDown exits incremental search but lineUp doesn't.

Small fix
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=f04e86427fce666bd54549d135d7c118fd3f9abe