Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 335631 - [client] prompting when leaving a dirty editor no longer works for just a hash change
Summary: [client] prompting when leaving a dirty editor no longer works for just a has...
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Susan McCourt CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-27 17:29 EST by Susan McCourt CLA
Modified: 2011-09-01 11:41 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Susan McCourt CLA 2011-01-27 17:29:52 EST 
When I refactored the services code, I removed a verifyInputChange callback that I thought was no longer necessary.  Turns out it is.  The symptom is that you get the dirty prompt when going to another document (because we have onbeforeunload handling in the page) but not when the hash changes.

I'll make a surgical fix for M5 and a real fix in M6 with bug 334195.
Comment 1 Susan McCourt CLA 2011-01-27 19:16:01 EST 
Actually, this has been broken since at least M4.
One challenge here is that if we want to prompt when changing the hash, we have to make sure we don't prompt if the only change is moving around among line numbers (such as using the outliner)
Comment 2 Susan McCourt CLA 2011-01-27 20:01:14 EST 
Even though this is not a regression, it is a bad bug (loss of data). 
Released fix and tagged for 2am build.