Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 335608 - [BiDi] Cannot launch with com.ibm.icu.base
Summary: [BiDi] Cannot launch with com.ibm.icu.base
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.7   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.7 M6   Edit
Assignee: Oleg Besedin CLA
QA Contact: Oleg Besedin CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-27 15:19 EST by Paul Webster CLA
Modified: 2011-03-08 13:25 EST (History)
2 users (show)

See Also:


Attachments
Patch (3.52 KB, patch)
2011-01-31 09:59 EST, Oleg Besedin CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Webster CLA 2011-01-27 15:19:17 EST
The fix for Bug 303889 has an unintended consequence.  We can no longer launch a workbench RCP app using com.ibm.icu.base (which can shave about 6M off of a 13M RCP app)

We might need a replacement for use of BiDi in the Platform plugins.

PW
Comment 1 Paul Webster CLA 2011-01-27 15:20:14 EST
I currently get an exception on startup that kills the org.eclipse.ui.workbench plugin:

Caused by: java.lang.NoClassDefFoundError: com.ibm.icu.text.Bidi
	at org.eclipse.ui.internal.WorkbenchPlugin.checkBidiSDK_NLSPacks(WorkbenchPlugin.java:949)
	at org.eclipse.ui.internal.WorkbenchPlugin.checkCommandLineLocale(WorkbenchPlugin.java:978)
	at org.eclipse.ui.internal.WorkbenchPlugin.getDefaultOrientation(WorkbenchPlugin.java:938)
	at org.eclipse.ui.internal.WorkbenchPlugin.start(WorkbenchPlugin.java:889)
	at org.eclipse.osgi.framework.internal.core.BundleContextImpl$1.run(BundleContextImpl.java:711)
	at java.security.AccessController.doPrivileged(AccessController.java:251)
	at org.eclipse.osgi.framework.internal.core.BundleContextImpl.startActivator(BundleContextImpl.java:702)
	... 37 more
Comment 2 Oleg Besedin CLA 2011-01-31 09:59:26 EST
Created attachment 187964 [details]
Patch
Comment 3 Oleg Besedin CLA 2011-01-31 10:02:34 EST
Dina, could you verify that this change does not break bug 303889?
Comment 4 Oleg Besedin CLA 2011-03-08 13:25:13 EST
Verified that build I20110307-2110 can be used with com.ibm.icu.base.