Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 335599 - [Compatibility] 'launcher' attribute for editor extensions are not considered
Summary: [Compatibility] 'launcher' attribute for editor extensions are not considered
Status: VERIFIED FIXED
Alias: None
Product: e4
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 1.0   Edit
Hardware: All All
: P3 critical (vote)
Target Milestone: 4.1 M6   Edit
Assignee: Remy Suen CLA
QA Contact: Remy Suen CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-27 13:36 EST by Olivier Thomann CLA
Modified: 2011-02-07 08:08 EST (History)
2 users (show)

See Also:

Attachments
External editor patch v1 (2.14 KB, patch)
2011-02-02 07:21 EST, Remy Suen CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2011-01-27 13:36:27 EST 
Using eclipse.buildId=I20110126-2200
java.version=1.6.0_24
java.vendor=Sun Microsystems Inc.
BootLoader constants: OS=win32, ARCH=x86_64, WS=win32, NL=fr_CA
Command-line arguments:  -os win32 -ws win32 -arch x86_64 -console,

I tried to select a xml file that I produced by exporting JUnit tests results.
I saved that file inside a simple project (jdt) inside my workspace.

I selected the file and tried "Right-Click">Open with>JUnit view.
I got an error about:
Executable extension definition for "class" not found.
And:
Unable to create part

The log contents is:

!ENTRY org.eclipse.ui 4 4 2011-01-27 13:34:10.159
!MESSAGE Unable to create part

!ENTRY org.eclipse.ui 4 1 2011-01-27 13:34:10.160
!MESSAGE Executable extension definition for "class" not found.

I am using a 4.1 build. So this might be a problem only with 4.1.
Comment 1 Remy Suen CLA 2011-01-27 13:46:32 EST 
I can reproduce this problem. The workaround would be to open the 'JUnit' view first and then importing it from there.
Comment 2 Remy Suen CLA 2011-01-27 14:25:30 EST 
Our code doesn't take into IEditorLauncher implementations specified by the 'launcher' attribute so we end up trying to create a new editor (which fails).

Another related problem is that there is no stack trace in the error log which makes it slightly less obvious where the problem is. We also need to correct this.
Comment 3 Dani Megert CLA 2011-01-28 02:41:18 EST 
This also breaks opening the JAR Export wizard.
Comment 4 Remy Suen CLA 2011-02-02 07:21:17 EST 
Created attachment 188130 [details]
External editor patch v1
Comment 5 Remy Suen CLA 2011-02-02 07:23:00 EST 
(In reply to comment #4)
> Created attachment 188130 [details]
> External editor patch v1

Both issues contained in comment 2 has been addressed. Patch released to CVS HEAD. Thanks for the bug report, Olivier!
Comment 6 Remy Suen CLA 2011-02-02 07:23:35 EST 
Whoops.
Comment 7 Dani Megert CLA 2011-02-07 08:08:11 EST 
Verified in I20110204-0715.