Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 335581 - Change "boo" into command to insert block comment
Summary: Change "boo" into command to insert block comment
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: John Arthorne CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-27 10:46 EST by John Arthorne CLA
Modified: 2011-09-01 11:42 EDT (History)
1 user (show)

See Also:


Attachments
Screen shot (9.20 KB, image/png)
2011-01-27 10:47 EST, John Arthorne CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2011-01-27 10:46:55 EST
N201101270200

When in coding.html, there is a link at the top right that says, "boo". Unless this is illustrating something important it should be removed from M5. It might scare the kids.
Comment 1 John Arthorne CLA 2011-01-27 10:47:15 EST
Created attachment 187740 [details]
Screen shot
Comment 2 John Arthorne CLA 2011-01-27 10:47:56 EST
The lowercase "e" that converts text to uppercase is also a bit odd, but at least it does something useful.
Comment 3 Boris Bokowski CLA 2011-01-27 11:45:26 EST
I agree it needs to be removed, I put this in temporarily. See the comments in coding.js.
Comment 4 John Arthorne CLA 2011-01-27 11:47:32 EST
I have a better idea for an example:

	serviceRegistry.registerService("editorAction", {
	 info: function() {return {name:"Comment"};},
	 run: function(selectedText, text, selection) { return {text: text.substring(0,selection.start) + "/*" + text.substring(selection.start,selection.end) + "*/" + text.substring(selection.end),
	 selection: {start:selection.start,end:selection.end+4}}; }
	});


This command converts the selection to a block comment. I think it is a useful example that illustrates how to use the various arguments, and does something useful enough that we can leave it in.
Comment 5 John Arthorne CLA 2011-01-27 11:55:58 EST
I released my block comment example instead.