Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 335432 - LastUpdateTimestamp not set for committing Transaction
Summary: LastUpdateTimestamp not set for committing Transaction
Status: CLOSED FIXED
Alias: None
Product: EMF
Classification: Modeling
Component: cdo.core (show other bugs)
Version: 4.0   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Pascal Lehmann CLA
QA Contact: Eike Stepper CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 335106
  Show dependency tree
 
Reported: 2011-01-26 05:16 EST by Pascal Lehmann CLA
Modified: 2011-06-23 03:37 EDT (History)
0 users

See Also:
stepper: review+

Attachments
patch (576 bytes, patch)
2011-01-26 05:17 EST, Pascal Lehmann CLA 		no flags Details | Diff
Patch v2 - ready to be committed (2.51 KB, patch)
2011-01-26 06:03 EST, Eike Stepper CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Lehmann CLA 2011-01-26 05:16:52 EST 
The lastUpdateTimestamp for CDOViews is updated in the invalidate method. For the committing transaction however inivalidate is never called and therefore the timestamp is not updated.
This can cause wrong results when merging since the own changes (if there have been no other changes later) won't end up in the changeSet because the lastUpdateTimestamp is not updated and therefore the revisions are never fetched from the cache.
Comment 1 Pascal Lehmann CLA 2011-01-26 05:17:39 EST 
Created attachment 187625 [details]
patch

patch to update lastUpdateTimestamp when committing.
Comment 2 Eike Stepper CLA 2011-01-26 06:03:25 EST 
Created attachment 187628 [details]
Patch v2 - ready to be committed

I've re-added InternalCDOView.setLastUpdateTime(). It was present in 3.0 already. And I've added a simple test case. Go ahead please ;-)
Comment 3 Pascal Lehmann CLA 2011-01-26 07:52:53 EST 
Committed revision 6933:
- trunk/plugins/org.eclipse.emf.cdo.server
- trunk/plugins/org.eclipse.emf.cdo.tests
- trunk/plugins/org.eclipse.emf.cdo
Comment 4 Eike Stepper CLA 2011-06-23 03:37:16 EDT 
Available in R20110608-1407