Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 335431 - [Nattable] Cannot close the cell editor without calling commit()
Summary: [Nattable] Cannot close the cell editor without calling commit()
Status: CLOSED INVALID
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: EMF-Facet (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-26 05:04 EST by Camille Letavernier CLA
Modified: 2020-05-01 11:26 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Camille Letavernier CLA 2011-01-26 05:04:14 EST 
Build Identifier: I20101208-1300

When using custom IModelCellEditor which don't use the IModelCellEditHandler#commit() method, we cannot close the cell. It would be useful to have either a #close() method in org.eclipse.emf.facet.widgets.celleditors.IModelCellEditHandler, or an access to the org.eclipse.jface.viewers.CellEditor instance (For example by adding a parameter to IModelCellEditor#activateCell())

The reason why we don't use IModelCellEditHandler#commit() is that we use a different method to validate modifications, which would be redundant with #commit().

Reproducible: Always
Comment 1 Nicolas Guyomar CLA 2011-02-07 05:31:35 EST 
Hi Camille,

I do not understand the problem here.

Could you please attached to this bug an example of custom cell editor ?


It seems to me that if you do not use the IModelCellEditHandler#commit() method, then you just have to implement a close() method in your own code.

Our cellEditor composites use org.eclipse.emf.facet.widgets.celleditors.AbstractCellEditorComposite.close()

Regards,
Nicolas
Comment 2 Vincent Lorenzo CLA 2011-02-21 07:33:44 EST 
Resolved