Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 335394 - IllegalArgumentException when task attachments do not specify a URL
Summary: IllegalArgumentException when task attachments do not specify a URL
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.5   Edit
Assignee: Thomas Ehrnhoefer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2011-01-25 17:31 EST by Thomas Ehrnhoefer CLA
Modified: 2011-01-25 19:40 EST (History)
1 user (show)

See Also:

Attachments
patch (2.31 KB, patch)
2011-01-25 17:33 EST, Thomas Ehrnhoefer CLA 		no flags Details | Diff
mylyn/context/zip (3.88 KB, application/octet-stream)
2011-01-25 17:33 EST, Thomas Ehrnhoefer CLA 		no flags Details
patch v2 (+test) (7.32 KB, patch)
2011-01-25 17:53 EST, Thomas Ehrnhoefer CLA 		steffen.pingel: iplog+
Details | Diff
mylyn/context/zip (55.34 KB, application/octet-stream)
2011-01-25 17:53 EST, Thomas Ehrnhoefer CLA 		no flags Details
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Ehrnhoefer CLA 2011-01-25 17:31:01 EST 
if a url is not specified, there are some problems in the UI :

if url is null: 
NPE at: @org.eclipse.mylyn.internal.tasks.ui.editors.AttachmentTableLabelProvider.getAttachmentId(AttachmentTableLabelProvider.java:133)@

if url is empty string:
IllegalArgumentException at: @at org.eclipse.mylyn.internal.tasks.ui.util.TasksUiMenus$1.run(TasksUiMenus.java:39)@
Comment 1 Thomas Ehrnhoefer CLA 2011-01-25 17:33:58 EST 
Created attachment 187586 [details]
patch
Comment 2 Thomas Ehrnhoefer CLA 2011-01-25 17:33:59 EST 
Created attachment 187587 [details]
mylyn/context/zip
Comment 3 Thomas Ehrnhoefer CLA 2011-01-25 17:53:14 EST 
Created attachment 187589 [details]
patch v2 (+test)
Comment 4 Thomas Ehrnhoefer CLA 2011-01-25 17:53:16 EST 
Created attachment 187590 [details]
mylyn/context/zip
Comment 5 Steffen Pingel CLA 2011-01-25 19:39:56 EST 
Thanks Thomas! I have applied the patch.