Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 335360 - Conditional Breakpoints history popup menu should skip newline and indent
Summary: Conditional Breakpoints history popup menu should skip newline and indent
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 3.7 M5   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-25 13:30 EST by Markus Keller CLA
Modified: 2011-01-27 03:08 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2011-01-25 13:30:56 EST
I20110124-1800

The Conditional Breakpoints history popup menu in the Breakpoints view should show more content. It should skip newline and indent and replace it with a single space.

Currently, I can't tell these two entries apart:

1:
System.out.println("log");
return false;

2:
System.out.println("log");
return true;


The labels should probably still be capped, but filling half the screen width would still be OK.
Comment 1 Dani Megert CLA 2011-01-26 02:36:59 EST
> It should skip newline and indent and replace it with a single space.
I disagree on the space because
"foo bar"
and
foo
bar
would end up as two entries but same text.

How about using \n? This would probably lead to less collisions.
Comment 2 Dani Megert CLA 2011-01-26 07:04:08 EST
> > It should skip newline and indent and replace it with a single space.
> I disagree on the space because
> "foo bar"
> and
> foo
> bar
> would end up as two entries but same text.
> 
> How about using \n? This would probably lead to less collisions.

Discussed this with Markus and got convinced that it's better to use a space.


Fixed in HEAD.
Available in builds >= I20110126-0800.(In reply to comment #1)
Comment 3 Dani Megert CLA 2011-01-27 03:08:58 EST
Verified in I20110126-1800.