Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 335336 - [editor] Add Extensions Components Dialog does not appear
Summary: [editor] Add Extensions Components Dialog does not appear
Status: CLOSED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.xsd (show other bugs)
Version: 3.2.3   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.2.3   Edit
Assignee: Keith Chong CLA
QA Contact: Keith Chong CLA
URL:
Whiteboard: PMC_approved
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-25 11:16 EST by Keith Chong CLA
Modified: 2011-01-29 12:38 EST (History)
4 users (show)

See Also:
david_williams: pmc_approved+
nsand.dev: pmc_approved? (raghunathan.srinivasan)
nsand.dev: pmc_approved? (naci.dai)
nsand.dev: pmc_approved? (deboer)
nsand.dev: pmc_approved? (neil.hauge)
nsand.dev: pmc_approved? (kaloyan)
nsand.dev: review+
thatnitind: review+

Attachments
Apply to org.eclipse.wst.xsd.ui (1.36 KB, patch)
2011-01-25 11:35 EST, Keith Chong CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Chong CLA 2011-01-25 11:16:35 EST 
In the Extensions tab of the properties page of the XML Schema Editor, if you click the Add button, nothing visibly happens....the Add Extension Components dialog does not appear. 

This is happening in an adopter product and not in WTP.
Comment 1 Keith Chong CLA 2011-01-25 11:35:33 EST 
Created attachment 187536 [details]
Apply to org.eclipse.wst.xsd.ui
Comment 2 Keith Chong CLA 2011-01-25 11:36:55 EST 
The problem is that there is a NullPointerException in BaseCommand.

The adopter was passing a null String to the Extensible*Commands which inherit from BaseCommand.   The BaseCommand should guard against a null string.
Comment 3 Keith Chong CLA 2011-01-25 11:50:52 EST 
1. Explain why you believe this is a stop-ship defect. Or, if it is a "hotbug" (requested by an adopter) please document it as such. 
Requested by adopter.

2. Is there a work-around? If so, why do you believe the work-around is insufficient?
No, the dialog does not appear at all.

3. How has the fix been tested? Is there a test case attached to the bugzilla record? Has a JUnit Test been added? 
Tested manually in adopter product and is fixed.

4. Give a brief technical overview. Who has reviewed this fix?
In BaseCommand, the string 'label' was referenced but did not check that it could be null.   Yen Lu reviewed this fix.

5. What is the risk associated with this fix? 
Low.  The fix just guards against a null string.
Comment 4 Keith Chong CLA 2011-01-25 11:53:04 EST 
Hi Nitin, please review and submit for PMC approval.

Thanks in advance.
Comment 5 Nick Sandonato CLA 2011-01-25 13:21:36 EST 
Patch looks appropriate. I approve. Flagging for PMC approval.
Comment 6 Keith Chong CLA 2011-01-27 14:12:54 EST 
I released this for 3.2.3.
Comment 7 Ivan Castro CLA 2011-01-27 16:45:33 EST 
Verified in Smoke Test R323 01272011.
Comment 8 Keith Chong CLA 2011-01-27 16:52:36 EST 
Thanks Ivan, closing bug.