Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 335310 - RemoteServiceClientRegistration#properties field does not check for null
Summary: RemoteServiceClientRegistration#properties field does not check for null
Status: RESOLVED FIXED
Alias: None
Product: ECF
Classification: RT
Component: ecf.remoteservices (show other bugs)
Version: 3.5.0   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: ecf.core-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-25 08:45 EST by Pavel Samolisov CLA
Modified: 2011-01-25 12:04 EST (History)
2 users (show)

See Also:

Attachments
A result (only 2 if (properties == null) added (4.62 KB, application/octet-stream)
2011-01-25 08:45 EST, Pavel Samolisov CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pavel Samolisov CLA 2011-01-25 08:45:10 EST 
Created attachment 187516 [details]
A result (only 2 if (properties == null) added

In the RemoteServiceClientRegistration class's methods the dictionary property does not check for null, i.e. in methods getPropertyKeys or getProperty. This is leads to NPE when this class is used, i.e. for call via Proxy (in developed now XML-RPC provider).

I added this checkings, see the result. I can commit this stuff today evening (on MSK time) if you do not have any objections.
Comment 1 Scott Lewis CLA 2011-01-25 10:58:49 EST 
Hi Pavel.  No objections from me...the null check change looks fine to me.  Please feel free to commit, push to master and resolve this bug.