Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 335276 - compile errors with near M5 platform
Summary: compile errors with near M5 platform
Status: RESOLVED FIXED
Alias: None
Product: Java Server Faces
Classification: WebTools
Component: Core (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 3.3   Edit
Assignee: Ian Trimble CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-25 00:36 EST by David Williams CLA
Modified: 2017-12-19 13:26 EST (History)
1 user (show)

See Also:

Attachments
compile log showing ERROR: in test bundle (239.96 KB, text/html)
2011-01-25 00:36 EST, David Williams CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Williams CLA 2011-01-25 00:36:27 EST 
Created attachment 187494 [details]
compile log showing ERROR: in test bundle

The build machine is currently hosed up ... but, in a local build, I see that moving up to latest platform build causes some compile errors. 

I tried moving to 
I20110118-0800

4 errors in "main" code seemed to all have to do with 'BaseSaveAction' no longer being around? (or, changed packages?) 

Source File: org/eclipse/jst/jsf/facesconfig/ui/FacesConfigEditor.java
    1. ERROR: ImportNotFound

    The import org.eclipse.ui.internal.BaseSaveAction cannot be resolved

    FacesConfigEditor.java :

    101 : import org.eclipse.ui.internal.BaseSaveAction;


There were 15 more in a test plugin, for which I'll attach the compile log. 

Just wanted to give a little early warning ... especially since build machine is "dead" we likely won't get new build until Tuesday noonish, or so.
Comment 1 Ian Trimble CLA 2011-01-25 14:05:26 EST 
Code previously added to address Bug 263806 relied on internal classes that have since been removed. Bug 263806 no longer requires the code that was added in order to function correctly, and so the old fix for Bug 263806 has simply been removed.

This addresses "main" code issues - test fixes are still required.
Comment 2 Ian Trimble CLA 2011-01-25 14:30:52 EST 
Platform resource changes necessitated updates to our mock resource test objects.
Comment 3 Ian Trimble CLA 2011-01-25 14:35:44 EST 
Raghu, please review for PMC approval. I have successfully tested the failure to save from source tab scenario manually and have successfully run all JUnit tests that use the affected mock resource objects.
Comment 4 Ian Trimble CLA 2011-01-25 14:36:21 EST 
My mistake, this is for 3.3, not 3.2.3 - no PMC approval required.
Comment 5 Ian Trimble CLA 2011-01-25 14:44:45 EST 
Committed to HEAD (3.3 stream) at 2011/01/25 11:43AM PDT.
Comment 6 David Williams CLA 2011-01-25 20:09:51 EST 
It appears the fixes for 'test' code did not get released? 

http://build.eclipse.org/webtools/committers/wtp-R3.3.0-I/20110125225544/I-3.3.0-20110125225544/
Comment 7 Raghunathan Srinivasan CLA 2011-01-25 23:35:42 EST 
Test changes also released.
Comment 8 Eclipse Genie CLA 2017-12-18 20:16:41 EST 
New Gerrit change created: https://git.eclipse.org/r/114265