Community
Participate
Working Groups
This copy of the bug will handle the Common "compile errors". I have reduced the list of errors to those that should be handled. +++ This bug was initially created as a clone of Bug #334948 +++ The following is what I get in an updated cvs tree when imported into a wtp 3.3 m4 environment. Most of these are in the common module but some are in jeetools. Carl has replicated that these *are* coding errors, places that could use the small suggested cleanup below, though we haven't figured out why they show up as errors in my workspace and not his. Compiler settings for these projects tend to be overrided on a by-project level, and they do mark these as errors, but for some reason Carl does not get compile errors and I do. Either way, the following lines of code could use some cleanup ;) Description Resource Path Location Type line 49 Java Problem Java Problem The field ErrorDialog.message is hiding a field from type IconAndMessageDialog ErrorDialog.java /org.eclipse.wst.common.frameworks.ui/wtp_ui/org/eclipse/wst/common/frameworks/internal/ui line 46 Java Problem Potential null pointer access: The variable group1 may be null at this location AscendingGroupComparator.java /org.eclipse.wst.common.frameworks/src/org/eclipse/wst/common/frameworks/internal/enablement line 41 Java Problem Potential null pointer access: The variable group1 may be null at this location DescendingGroupComparator.java /org.eclipse.wst.common.frameworks/src/org/eclipse/wst/common/frameworks/internal/enablement line 42 Java Problem Potential null pointer access: The variable group2 may be null at this location AscendingGroupComparator.java /org.eclipse.wst.common.frameworks/src/org/eclipse/wst/common/frameworks/internal/enablement line 41 Java Problem Potential null pointer access: The variable group2 may be null at this location DescendingGroupComparator.java /org.eclipse.wst.common.frameworks/src/org/eclipse/wst/common/frameworks/internal/enablement line 42 Java Problem
The field ErrorDialog.message hiding a superclass' field is valid. The "errors" in AscendingGroupComparator and DescendingGroupComparator are not valid - it is impossible for group1 or group2 to be null. This appears to be a regression in the JDT.
Sorry for opening a new bug, I didn't see this one, but the newer one already has a patch, review request, and PMC questions answered *** This bug has been marked as a duplicate of bug 345518 ***
