Description Tonny Madsen 2011-01-21 06:19:33 EST

When using multiple dispose listener for the same observable, a later listener in the list can occasionally be called after the observable has been disposed completely.

In this case the disposeListener of Binding can be called with context == null resulting in an NPE.

To solve this change the code of Binding.init() to

	public final void init(DataBindingContext context) {
		this.context = context;
		if (target.isDisposed())
			throw new IllegalArgumentException("Target observable is disposed"); //$NON-NLS-1$
		if (model.isDisposed())
			throw new IllegalArgumentException("Model observable is disposed"); //$NON-NLS-1$
		this.disposeListener = new IDisposeListener() {
			public void handleDispose(DisposeEvent staleEvent) {
				if (isDisposed()) return;
				Binding.this.context.getValidationRealm().exec(new Runnable() {
					public void run() {
						if (!isDisposed())
							dispose();
					}
				});
			}
		};
		target.addDisposeListener(disposeListener);
		model.addDisposeListener(disposeListener);
		preInit();
		context.addBinding(this);
		postInit();
	}



-- Configuration Details --
Product: Eclipse 1.3.1.20100913-1228 (org.eclipse.epp.package.rcp.product)
Installed Features:
 org.eclipse.platform 3.6.1.r361_v20100909-9gF78GrkFqw7GrsZnvz0JWNTeb6fue6896L