Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334976 - [Webapp] file handle leaks in help system
Summary: [Webapp] file handle leaks in help system
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 M5   Edit
Assignee: platform-ua-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-21 01:53 EST by Rupesh Kumar CLA
Modified: 2011-01-21 17:27 EST (History)
3 users (show)

See Also:

Attachments
Fix for unclosed handle (1.38 KB, patch)
2011-01-21 01:57 EST, Rupesh Kumar CLA 		cgold: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rupesh Kumar CLA 2011-01-21 01:53:32 EST 
Build Identifier: 3.6.1

Help system is leaking file handles (opening file input streams and not explicitly closing them). We need to validate that file handles are being left open and provide a fix.

Reproducible: Sometimes
Comment 1 Rupesh Kumar CLA 2011-01-21 01:55:13 EST 
I have used the FindBugs a code analysis tool (free under GNU License), which really helped me to get the kind of code analysis I was looking.  To integrate FindBugs with Eclipse use the following link : http://findbugs.sourceforge.net/manual/eclipse.html. Very nice feature is that it provides the flexibility to select the individual bugs test e.g. OBL(description: Method may fail to clean up stream or resource) & OS (Description: Method may fail to close stream). To get more detailed description of the available bugs analysis using FindBugs refer : http://findbugs.sourceforge.net/bugDescriptions.html
Comment 2 Rupesh Kumar CLA 2011-01-21 01:57:08 EST 
Created attachment 187261 [details]
Fix for unclosed handle

I after running through FindBugs tool, I found one unclosed handle and I fixed it. Please find the fix in the patch.
Comment 3 Chris Goldthorpe CLA 2011-01-21 17:10:41 EST 
I reviewed your patch and it looks good. I will commit it next week.
Comment 4 Chris Goldthorpe CLA 2011-01-21 17:27:07 EST 
Patch committed to HEAD, Fixed