Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334969 - [terminal] Terminal fails to interpret multi-command SGR sequence
Summary: [terminal] Terminal fails to interpret multi-command SGR sequence
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: Terminal (show other bugs)
Version: 3.3   Edit
Hardware: All All
: P2 major (vote)
Target Milestone: 3.3 M5   Edit
Assignee: Martin Oberhuber CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 335410
  Show dependency tree
 
Reported: 2011-01-20 20:37 EST by Martin Oberhuber CLA
Modified: 2011-01-25 21:26 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2011-01-20 20:37:11 EST 
CQ:WIND00246476

As per http://en.wikipedia.org/wiki/Ansi_terminal the ANSI "Set Graphics Rendition" command must support multiple subcommands, for example:

[1;37;40m

to set bold, white foreground, black background. The current terminal fails to interpret such multi-command style changes and applies the last change of such a sequence only (in this case: black background).

The net effect is that on some systems, this can result in black-on-black text which is unreadable and thus a severe problem.
Comment 1 Martin Oberhuber CLA 2011-01-20 20:47:51 EST 
Problem was that in VT100Emulator.processAnsiCommand_m(), the current state of a style was not carried from one SGR sub-command to the next.

Fixed.
Comment 2 Martin Oberhuber CLA 2011-01-20 20:48:38 EST 
While at it, I also implemented the "blink" and "underline" attributes.