Community
Participate
Working Groups
The about.html file from the JVMTI plug-in is missing from the javaprofiler zips. The packaging should be updated to include the missing file.
Created attachment 187243 [details] about.html patch Hey Joel, please review the patch, and check it in. thanks, Sam
Patch looks good.
Patch checked into HEAD on behalf of Sam.
Resolved. Changes were picked up by build: TPTP-4.7.2-201101201646
Verified.
The license referenced in the about.html file should be packaged in the JVMTI plug-in.
Created attachment 187307 [details] Alternative way of adding about.html from Makefile Hey Joel, Could you take a look at these patches and check them in. Instead of adding about.html during the build, it should be added during the make makefile. Thanks, Sam
Created attachment 187308 [details] customTargets
Created attachment 187351 [details] License files Patch for jvmti and jvmti.sdk Hey Joel, Adding about_files under org.eclipse.tptp.platform.jvmti.runtime which contains LICENSE-2.0.txt and NOTICE. Javaprofiler zip and javaprofiler.sdk now contain about_files and about.html. please review the patch thanks Sam
Created attachment 187352 [details] agntctrl about.html patch This patch contains the fix for about.html in agent controller. It should be about_files/LICENSE not about_files/LICENSE-2.0.txt.
Please ensure a comment is added to the makefiles to explain that the about.html and about_files are removed during packaging the jvmti-only zip as they are included in the JVMTI workbench plug-in at the root level of the plug-in. We should verify that the correct contents are included for the NOTICE file. Patches for customTargets, agentcontroller, and JVMTI look good.
Created attachment 187439 [details] Update License files Patch for jvmti and jvmti.sdk Comments are add on the makefiles.
I would like to request that the following defect be considered for PMC approval for 4.7.2. 1. Explain why you believe this is a stop-ship defect. How does the defect manifest itself, and how will users of TPTP / consuming products be affected if the defect is not fixed? License files (about.html and about_files) are missing in jvmti plugins. 2. Is there a work-around? If so, why do you believe the work-around is insufficient? No. 3. Is this a regression or API breakage? Explain. No. 4. Does this require new API? No. 5. Who performed the code review? Joel 6. Is there a test case attached to the bugzilla record? N/A 7. What is the nature of the fix? What is the risk associated with this fix? The fix modifies the makefiles in jvmti plugin that are missing about.html and license files. The fix is low risk. 8. Is this fix related to any standards that TPTP adheres to? If so, who has validated that the fix continues to adhere to the standard? N/A
Requesting PMC approval for TPTP 4.7.2.
Hey Joel, Could you review and check in the patch. Thanks, Sam
Patches for customTargets, AC, and JVMTI have been checked into HEAD.
Verified in build TPTP-4.7.2-201101261720
Files are missing in org.eclipse.tptp.platform.jvmti.runtime\agent_files\linux_em64t and \linux_ia32. Reopening.
Created attachment 187765 [details] jvmti fix missing files Hey Jon, Could you review and check in the patch, Thanks, Sam
Patch checked into HEAD.
Resolving.
Verified in build TPTP-4.7.2-201101271445 Correct files are shown up under org.eclipse.tptp.platform.jvmti.runtime\agent_files\linux_em64t and \linux_ia32
Verified on TPTP-4.7.2-201101271445.
