Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334905 - [client] Code Duplication in HTML files
Summary: [client] Code Duplication in HTML files
Status: RESOLVED FIXED
Alias: None
Product: Orion
Classification: ECD
Component: Client (show other bugs)
Version: 0.2   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.2   Edit
Assignee: Project Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-20 10:42 EST by Nathan Gervais CLA
Modified: 2011-09-01 11:41 EDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nathan Gervais CLA 2011-01-20 10:42:52 EST 
When I updated the files to use the new Orion word mark I had to edit 3 HTML files to do so, all containing the same code but were just replicated for each page (navigate-tree.html, navigate-table.html, and coding.html).  Likewise for adding the Demo Warning Footer to the pages.   From my previous experience this always seems to result in one file being forgotten in an update.
Comment 1 Susan McCourt CLA 2011-01-20 10:50:59 EST 
see also bug 334191.  That one is focused more on UI rearranging, but implied in that was some cleanup along these lines.
Comment 2 John Arthorne CLA 2011-04-04 11:48:19 EDT 
We have a common header and footer in place for M6. See /static/js/globalCommands.js.

However there are still some issues due to this code being copied during minification. This is being looked at for M7 in bug 340019.