Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334885 - I get this exception while trying to perform static instrumentation. I get the error message cannot perform static instrumentation see error log
Summary: I get this exception while trying to perform static instrumentation. I get th...
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: TPTP (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows Vista
: P2 major (vote)
Target Milestone: ---   Edit
Assignee: Samuel Wu CLA
QA Contact: Kathy Chan CLA
URL:
Whiteboard: closed472
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-20 09:01 EST by asethu5 CLA
Modified: 2016-05-05 10:37 EDT (History)
3 users (show)

See Also:
kathy: pmc_approved? (oec)
kathy: pmc_approved? (ernest)
kathy: pmc_approved? (kathy)
jgwest: pmc_approved+
kathy: pmc_approved? (jerome.bozier)
jcayne: review+


Attachments
this is the stack trace of the warning that I get (4.70 KB, text/plain)
2011-01-20 09:03 EST, asethu5 CLA
no flags Details
config details (468.17 KB, text/plain)
2011-01-21 11:21 EST, asethu5 CLA
no flags Details
ProbeKit Plugin (981 bytes, patch)
2011-01-26 15:54 EST, Samuel Wu CLA
no flags Details | Diff
Package ProbeKit (3.74 KB, patch)
2011-01-26 15:56 EST, Samuel Wu CLA
no flags Details | Diff
Update plugin number (747 bytes, patch)
2011-01-27 10:15 EST, Kathy Chan CLA
no flags Details | Diff
Update feature version number (1.35 KB, patch)
2011-01-27 10:16 EST, Kathy Chan CLA
no flags Details | Diff
Package ProbeKit Update (1.09 KB, patch)
2011-01-27 11:00 EST, Samuel Wu CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description asethu5 CLA 2011-01-20 09:01:50 EST
Build Identifier: 20100617-1415

The java program compiles and runs normally, but when I try to insert a probe and perform static instrumentation, I get this error.

Reproducible: Always

Steps to Reproduce:
1.probe i used ,uses before call, no import and targets, and a java code
2.
3.
Comment 1 asethu5 CLA 2011-01-20 09:03:36 EST
Created attachment 187181 [details]
this is the stack trace of the warning that I get
Comment 2 Kathy Chan CLA 2011-01-20 09:23:04 EST
Mike, 

Please take a look and get Paul's help if necessary.  Thanks!
Comment 3 Mike Reid CLA 2011-01-20 16:37:08 EST
Hi,

Can you collect the information on the Help > About > Installation Details > Configuration tab?

I am unable to reproduce this using the latest build, neither on Windows or Linux. However, in looking at into the code I am wondering if you are running on a 64-bit machine with a 64-bit JVM?

Thanks,
/mike.
Comment 4 asethu5 CLA 2011-01-21 11:21:23 EST
Created attachment 187298 [details]
config details
Comment 5 Mike Reid CLA 2011-01-21 11:41:39 EST
Thanks. This confirms my suspicion that you are running a 64-bit JVM.

The static instrumentation is carried out by a native .exe that is packaged with the TPTP plugins. Currently only a 32-bit .exe is provided and so the problem is that we are failing to find a 64-bit .exe with which to instrument the class(es).

I need to dig deeper to find out why no 64-bit version is included, but in the meantime you can perform the instrumentation by installing a 32-bit JVM and running Eclipse with that JVM.
Comment 6 Mike Reid CLA 2011-01-26 14:09:41 EST
The problem is that the packaging scripts don't include the 64-bit versions of probeinstrumenter.

Sam, can you see what is involved in altering the build scripts to package this?
Comment 7 Mike Reid CLA 2011-01-26 15:23:16 EST
To clarify what we are missing; if you look in the existing package for org.eclipse.hyades.probekit plugin, you'll find:

 .../plugins/org.eclipse.hyades.probekit_4.3.1.v201009131917/os/win32/x86/
   BCIEngProbe.dll
   ProbeAgentExtension.dll
   ProbeInstrumenter.exe
   
 .../plugins/org.eclipse.hyades.probekit_4.3.1.v201009131917/os/linux/x86/
   BCIEngProbe.so
   ProbeAgentExtension.so
   probeinstrumenter 

We need corresponding copies under:

 os/win32/x86_64
 os/linux/x86_64
 
Unless I am mistaken, it appears that the Eclipse workbench is not available on IPF, so we don't need to bother with that architecture.
Comment 8 Samuel Wu CLA 2011-01-26 15:54:45 EST
Created attachment 187685 [details]
ProbeKit Plugin
Comment 9 Samuel Wu CLA 2011-01-26 15:56:04 EST
Created attachment 187686 [details]
Package ProbeKit

Hey Joel,

Could you review these two patches?
Thanks,

Sam
Comment 10 Joel Cayne CLA 2011-01-26 16:21:39 EST
A \ should be added in the p2.inf at the end of the 4th line.

Patch looks good.
Comment 11 Samuel Wu CLA 2011-01-26 16:29:41 EST
I would like to request that the following defect be considered for PMC approval for 4.7.2.

1.  Explain why you believe this is a stop-ship defect. How does the defect manifest itself, and how will users of TPTP / consuming products be affected if the defect is not fixed?
Files are missing under os/linux and os/win32 in the prokekit plugin 

2. Is there a work-around? If so, why do you believe the work-around is
insufficient?

No.

3. Is this a regression or API breakage? Explain.

No.

4. Does this require new API?

No.

5. Who performed the code review?

Joel

6. Is there a test case attached to the bugzilla record?

N/A

7. What is the nature of the fix?  What is the risk associated with this fix?

The fix will include linux-em64t and windows-em64t BCIEngProbe, ProbeAgentExtension and ProbeInstrumenter in probekit plugin.

8. Is this fix related to any standards that TPTP adheres to? If so, who has validated that the fix continues to adhere to the standard?

No.
Comment 12 Kathy Chan CLA 2011-01-26 16:36:10 EST
Requesting PMC approval for TPTP 4.7.2.
Comment 13 Joel Cayne CLA 2011-01-26 17:09:08 EST
Checked the probekit and package patches into HEAD.

I made the update to the p2.inf as described in comment 10.
Comment 14 Kathy Chan CLA 2011-01-27 10:15:27 EST
Created attachment 187734 [details]
Update plugin number

Updating plugin version number for org.eclipse.hyades.probekit.
Comment 15 Kathy Chan CLA 2011-01-27 10:16:17 EST
Created attachment 187735 [details]
Update feature version number

Updating feature version number and copyright for org.eclipse.tptp.platform.probekit.
Comment 16 Kathy Chan CLA 2011-01-27 10:19:34 EST
Version numbers for org.eclipse.tptp.platform.probekit and org.eclipse.hyades.probekit need to be updated.
Comment 17 Kathy Chan CLA 2011-01-27 10:48:20 EST
Version number and copyright changes had been checked into HEAD.
Comment 18 Samuel Wu CLA 2011-01-27 11:00:44 EST
Created attachment 187742 [details]
Package ProbeKit Update

Hey Joel,

please review the patch and check it in
Thanks,

Sam
Comment 19 Joel Cayne CLA 2011-01-27 11:15:37 EST
Patch "Package Probekit Update" looks good. I updated the Copyright and checked the change into HEAD.
Comment 20 Samuel Wu CLA 2011-01-28 10:10:34 EST
Verified in build TPTP-4.7.2-201101271445. Files are now in the os/win32/x86_64 os/linux/x86_64 directories.
Comment 21 Kathy Chan CLA 2011-02-11 14:56:36 EST
Closing in TPTP 4.7.2 on behalf of the originator/owner.
Comment 22 Kathy Chan CLA 2011-02-11 14:57:29 EST
Closing.