Community
Participate
Working Groups
Build Identifier: 0.2 I201101171803 In coding.html, the editor does not appear when a filename contains the = (equals) character. Reproducible: Always Steps to Reproduce: 1. Log into Orion using navigate-table.html. 2. Create a file named "foo=bar.txt". 3. Click the file to open the coding page on it. 4. The editor does not appear.
I suspect this problem is not limited to "=". During testing the other day I noticed that DBCS chars were messed up (I didn't report the bug at the time caused it could have been a encoding problem on my end). What are the illegal characters for filename in orion ? For example, win32 does not allow \ / : * ? " < > |
I'll take an initial look to see where the problem is.
This is caused by the function eclipse.util.getPositionInfo. It assumes the presence of an = indicates there is position info, such as: /file/A&key1=value1 There is a bug in its logic that causes it to discard the entire path if it doesn't recognize the part before the '=' character as a parameter. That is easy to fix, but the deeper problem is that it should really be looking for this format: /file/A?key1=value1&key2=value2... I.e., unless there is an ? character to indicate a query, it shouldn't interpret & and = as being parameter delimiters at all. I don't know what parts of the client code might be relying on the current format so I'm punting back for someone with more client background to investigate.
I'll take a look.
Fixed >20110127 to make the hash look more like query. This means file names can't contain '?' but this seems more acceptable and also makes the hash part of our URL look more like a normal URL now Old style: http://localhost:8080/coding.html#file=http://localhost:8080/file/D/bundles/org.eclipse.orion.client.core/static/js/util.js&line=93 New style: http://localhost:8080/coding.html#http://localhost:8080/file/D/static/js/util.js?line=93
