Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334806 - Use new Gerrit change id as task key
Summary: Use new Gerrit change id as task key
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: 0.7   Edit
Hardware: All All
: P3 trivial (vote)
Target Milestone: 0.8   Edit
Assignee: Sascha Scholz CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-19 11:18 EST by Sascha Scholz CLA
Modified: 2012-02-04 08:25 EST (History)
1 user (show)

See Also:

Attachments
show key instead of numeric id (1.25 KB, patch)
2011-02-13 20:15 EST, Steffen Pingel CLA 		no flags Details | Diff
mylyn/context/zip (1.33 KB, application/octet-stream)
2011-02-13 20:15 EST, Steffen Pingel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sascha Scholz CLA 2011-01-19 11:18:02 EST 
Old Gerrit change ids will go away (don't know exactly when, currently they are deprecated). The old ids are the ones that are visible in the URLs, e.g. https://git.wdf.sap.corp:8080/#change,4221.

Instead, the new ids (available through Change.getKey()) should be used. As they are very long, a shortened from should be displayed in the task list (does Mylyn support this?)

Examples:

Full: Ie871eed7b92d8ab7a565f6cd830165d61d175ff6
Example shortened form: Ie871eed7
Comment 1 Steffen Pingel CLA 2011-01-19 15:17:05 EST 
You could use setTaskKey() in GerritConnector.updateTaskFromTaskData() to the IDs visible in the Task List. I am wondering though if that makes sense? Do users care about these IDs?
Comment 2 Sascha Scholz CLA 2011-01-19 15:46:29 EST 
I could remember at least the old Gerrit change ids and would like to see them in the task list. For the new ids I don't know yet.
Comment 3 Steffen Pingel CLA 2011-02-13 20:15:29 EST 
Created attachment 188862 [details]
show key instead of numeric id
Comment 4 Steffen Pingel CLA 2011-02-13 20:15:30 EST 
Created attachment 188863 [details]
mylyn/context/zip
Comment 5 Steffen Pingel CLA 2011-02-13 20:17:04 EST 
Here is a patch to make to show the key instead of the id in the task list (requires synchronization). I'm a little torn if that's better but it's certainly more consistent with the web UI that mostly uses the key.
Comment 6 Sascha Scholz CLA 2011-04-15 08:16:18 EDT 
The attached patchset changes the task key to the abbreviated form. I think it's not correct to use it that way because it may not be unique. I would prefer to have the full Id to internally identify the change/task, but display only the abbreviated form.
Comment 7 Steffen Pingel CLA 2011-05-07 19:33:34 EDT 
The task key does not need to be unique. The framework uses the task id to uniquely identify a task which is still the integer number (but only visible internally).
Comment 9 Steffen Pingel CLA 2011-05-08 05:22:32 EDT 
Any reason to remove the mapping for the URL field?
Comment 10 Sascha Scholz CLA 2011-05-08 09:26:58 EDT 
Only cleaned up some commented out code. The active mapping for task URL is some lines below.