Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334785 - New shared license mechanism does not work for source features
Summary: New shared license mechanism does not work for source features
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.7 M5   Edit
Assignee: pde-build-inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 332662
  Show dependency tree
 
Reported: 2011-01-19 09:14 EST by Dean Roberts CLA
Modified: 2011-01-20 14:45 EST (History)
2 users (show)

See Also:

Attachments
Patch to SourceGenerator and FeatureWriter (2.10 KB, patch)
2011-01-19 09:17 EST, Dean Roberts CLA 		no flags Details | Diff
Test Jar for Kim (424.66 KB, application/octet-stream)
2011-01-19 09:18 EST, Dean Roberts CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dean Roberts CLA 2011-01-19 09:14:37 EST 
Build Identifier: 

Create a source feature based on a feature that uses the new shared license mechanism.  The built source feature will not contain the shared license material

Reproducible: Always
Comment 1 Dean Roberts CLA 2011-01-19 09:17:55 EST 
Created attachment 187104 [details]
Patch to SourceGenerator and FeatureWriter

The SourceGenerator and FeatureWriter did not propogate the shared license information from the "main" feature to the generated source feature.

Corrected problem.  Local test works.  Will provide a test pdebuild.jar to Kim so she can run an Eclipse test build.
Comment 2 Dean Roberts CLA 2011-01-19 09:18:42 EST 
Created attachment 187105 [details]
Test Jar for Kim

Kim, could you please try a test build with this pdebuild.jar and let me know how it goes.
Comment 3 Kim Moir CLA 2011-01-19 20:23:18 EST 
Dean, this fixed the problem.  Thanks!  Please release for M5.
Comment 4 Andrew Niefer CLA 2011-01-20 14:45:05 EST 
I released the attached patch.