Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334756 - CVS Commit dialog commits comment "<Click here to enter a commit comment>"
Summary: CVS Commit dialog commits comment "<Click here to enter a commit comment>"
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: CVS (show other bugs)
Version: 3.7   Edit
Hardware: All All
: P3 major (vote)
Target Milestone: 3.7 M5   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-19 06:02 EST by Markus Keller CLA
Modified: 2011-01-26 02:24 EST (History)
2 users (show)

See Also:

Attachments
Fix (4.23 KB, patch)
2011-01-20 05:06 EST, Dani Megert CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2011-01-19 06:02:46 EST 
I20110114-1330, was OK in I20110104-0920, probably broken by bug 333812

The CVS Commit dialog now commits comment "<Click here to enter a commit comment>" when you just click "Finish" without entering a comment.

It should ask and (if the user proceeds) commit the empty message as before.
Comment 1 Tomasz Zarna CLA 2011-01-19 11:46:10 EST 
My fault, I'll try to fix asap.
Comment 2 Dani Megert CLA 2011-01-20 04:50:37 EST 
I can take this one.
Comment 3 Dani Megert CLA 2011-01-20 05:06:14 EST 
Fixed in CommitCommentArea.java rev. 1.55.
Available in builds >= N20110120-2000.

Tomek, please verify the fix if you have a chance.
Comment 4 Dani Megert CLA 2011-01-20 05:06:34 EST 
Created attachment 187173 [details]
Fix
Comment 5 Dani Megert CLA 2011-01-20 05:25:10 EST 
The fix is good for the scenario in comment 0 but if one explicitly selects the item from the list then it is not yet 100% working.
Comment 6 Dani Megert CLA 2011-01-20 05:35:48 EST 
(In reply to comment #5)
> The fix is good for the scenario in comment 0 but if one explicitly selects the
> item from the list then it is not yet 100% working.

FALSE ALARM! This happened because there was already a wrong entry in the commit history.
Comment 7 Dani Megert CLA 2011-01-20 05:36:25 EST 
.
Comment 8 Tomasz Zarna CLA 2011-01-21 06:18:53 EST 
I think I've found one case when the fix doesn't work:
1. Go to Team > CVS > Comment Templates in Preferences, you can go there directly from the commit dialog clicking on the link below comment area
2. Create a new, empty template: do not enter anything when "Enter Comment Template" dialog show up, just press Ok
3. Modify a file and do Team > Commit
4. On the "Commit Files" dialog. choose the newly created template from the combo below comment area. It will be visible in the list as "Template:".
5. Press Finish
=> You're not asked if you want to commit with an empty message, but I guess this is fine because you've explicitly choose a blank template
=> The problem is that the comment went with "<Click here to enter a commit comment>" message
Comment 9 Tomasz Zarna CLA 2011-01-21 06:21:56 EST 
The above problem has nothing to do with the fix. I was able to reproduce it with CommitCommentArea.java from I20110104-0800 (1.53), so neither bug 333812 nor bug 334756 (this one) have introduced it.
Comment 10 Dani Megert CLA 2011-01-24 04:10:28 EST 
(In reply to comment #9)
> The above problem has nothing to do with the fix. I was able to reproduce it
> with CommitCommentArea.java from I20110104-0800 (1.53),
I assume you filed a bug for that ;-). Bug #?
Comment 11 Tomasz Zarna CLA 2011-01-24 06:54:32 EST 
Of course I did, it's bug 335177. I don't understand why the bug # is so high ;)

Other then the thing from comment 8, found in N20110120-200, the fix looks good. Marking as verified. Thanks Dani.
Comment 12 Dani Megert CLA 2011-01-25 05:41:54 EST 
This is not fixed in I20110124-1800. Removing VERIFIED state so that we can verify it in an I-build.
Comment 13 Tomasz Zarna CLA 2011-01-25 09:17:48 EST 
The fix will be available in I20110125-2000, sorry for not tagging it for any I-build yesterday.
Comment 14 Dani Megert CLA 2011-01-26 02:24:04 EST 
Verified in I20110125-2012.