Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334739 - Include org.eclipse.equinox.console.supportability project from equinox incubator in the incubator build
Summary: Include org.eclipse.equinox.console.supportability project from equinox incub...
Status: VERIFIED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: Releng (show other bugs)
Version: 3.7   Edit
Hardware: PC Windows Vista
: P3 normal (vote)
Target Milestone: 3.7 M6   Edit
Assignee: Kim Moir CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-19 01:57 EST by Lazar Kirchev CLA
Modified: 2011-02-03 13:24 EST (History)
3 users (show)

See Also:


Attachments
orbit and equinox incubator map update (2.47 KB, patch)
2011-01-28 09:46 EST, Thomas Watson CLA
no flags Details | Diff
updated patch (5.50 KB, patch)
2011-02-02 11:00 EST, Kim Moir CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lazar Kirchev CLA 2011-01-19 01:57:41 EST
I have recently created the rt/org.eclipse.equinox/incubator/console/org.eclipse.equinox.console.supportability project. I would like to request that it is added to the equinox incubator build. The project has dependencies to the Equinox bundle and to org.apache.felix.gogo.runtime bundle, which is available in orbit repository - its project is tools/org.eclipse.orbit/org.apache.felix.gogo.runtime and the bundle is available from the orbit build.
Comment 1 Kim Moir CLA 2011-01-19 09:12:47 EST
Is there a CQ to include the org.apache.felix.gogo.runtime bundle in the Equinox project?  Should this bundle be included in any of the equinox features or should it just be available as a standalone bundle?
Comment 2 Lazar Kirchev CLA 2011-01-19 11:19:59 EST
(In reply to comment #1)
> Is there a CQ to include the org.apache.felix.gogo.runtime bundle in the
> Equinox project?  Should this bundle be included in any of the equinox features
> or should it just be available as a standalone bundle?

No, there is no CQ for including gogo runtime in the Equinox project. There are two CQs related with it - CQ 4561 to use it in the console supportability project, and CQ 4690 to include it in orbit. 

I think that currently, while the console supportability project is in the incubator, the gogo runtime bundle should not be included in the equinox features. It is enough to be available as a standalone bundle, as it already is from the orbit build.
Comment 3 Kim Moir CLA 2011-01-19 14:28:15 EST
Okay, I just looked at the CQs.  I see you have approval to include the org.apache.felix.gogo.runtime bundle in the equinox incubator project.  

Can you please add an entry for the org.eclipse.equinox.console.supportability bundle to the org.eclipse.releng maps project so it can be included in the build?

We usually include the dependent orbit bundles on the equinox page, if they aren't going to be included any of the equinox features.   Jeff, do you see any issues with this?
Comment 4 Jeff McAffer CLA 2011-01-19 15:39:45 EST
should be fine. I'm not sure that gogo needs to be on the pages right now (while incubating) but we'll hopefully be graduating the console stuff soon so will want gogo to be around then.  Note however that when the new console support graduates I would expect this all to be in the equinox sdk.
Comment 5 Lazar Kirchev CLA 2011-01-20 11:28:18 EST
(In reply to comment #3)

> Can you please add an entry for the org.eclipse.equinox.console.supportability
> bundle to the org.eclipse.releng maps project so it can be included in the
> build?

I do not have rights to modify this file - I am not a committer on the project.
Comment 6 Lazar Kirchev CLA 2011-01-28 01:44:06 EST
What should I do to have the console supportability project added to the incubator map file in the eclipse releng project? I do not have rights to change the map file myself.
Comment 7 Kim Moir CLA 2011-01-28 07:45:47 EST
Can you just update this bug with the location of the bundle and the tag you'd like to use and I'll update the map for a test build.  Going forward, you'll have to get an Equinox committer to tag it for the integration builds.  Btw, I didn't look at this bug this week because we were building M5 :-)
Comment 8 Lazar Kirchev CLA 2011-01-28 08:22:08 EST
(In reply to comment #7)
> Can you just update this bug with the location of the bundle and the tag you'd
> like to use and I'll update the map for a test build.  Going forward, you'll
> have to get an Equinox committer to tag it for the integration builds.  Btw, I
> didn't look at this bug this week because we were building M5 :-)

Thanks, Kim. Please feel free to update the map file when you have time. The location of the project in the Equinox incubator project is org.eclipse.equinox/incubator/console/org.eclipse.equinox.console.supportability. I would like to use the tag v201101201623 (it should be the only one available).
 
I think the record in the map file should look something like

plugin@org.eclipse.equinox.console.supportability=v201101201623,:pserver:anonymous@dev.eclipse.org:/cvsroot/rt,,org.eclipse.equinox/incubator/console/org.eclipse.equinox.console.supportability

If the test build is OK i will find someone to tag it for the integration builds.
Comment 9 Thomas Watson CLA 2011-01-28 09:46:23 EST
Created attachment 187845 [details]
orbit and equinox incubator map update

Kim, here are the updates to both the equinox-incubator.map to add the new equinox console bundle and to the orbit.map to add the new gogo.runtime bundle required to build the equinox console bundle.  I did not release the map file because I did not want to disrupt any M5 stuff.  Please release when you have a chance to do a test build.  Thanks.
Comment 10 Kim Moir CLA 2011-02-02 11:00:18 EST
Created attachment 188155 [details]
updated patch
Comment 11 Kim Moir CLA 2011-02-02 17:22:20 EST
This has been released for N20110202-2000.  

I noticed that the version of this bundle is 
Bundle-Version: 1.0.0
in your manifest.

Please update it to 
Bundle-Version: 1.0.0.qualifier

thanks :-)
Comment 12 Lazar Kirchev CLA 2011-02-03 01:01:14 EST
(In reply to comment #11)
> This has been released for N20110202-2000.  
> 
> I noticed that the version of this bundle is 
> Bundle-Version: 1.0.0
> in your manifest.
> 
> Please update it to 
> Bundle-Version: 1.0.0.qualifier
> 
> thanks :-)

Thanks for the reminder! It's done.
Comment 13 Kim Moir CLA 2011-02-03 10:11:36 EST
Thanks.  Feature tagged for integration build.  Closing.
Comment 14 Kim Moir CLA 2011-02-03 13:24:39 EST
Verified that this bundle appears in the Incubator section of this build.