Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334714 - SapphireCondition migration needs better documentation
Summary: SapphireCondition migration needs better documentation
Status: CLOSED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Sapphire (show other bugs)
Version: unspecified   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: ---   Edit
Assignee: Konstantin Komissarchik CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-18 16:43 EST by Shenxue Zhou CLA
Modified: 2021-11-19 09:22 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Shenxue Zhou CLA 2011-01-18 16:43:33 EST
Build Identifier: M20100909-0800

In Sapphire 0.2 release, there are a few new classes which extend SapphireCondition. For classes that need to be migrated to extend SapphireModelCondition rather than SapphireCondition, if they contain parameters, they need to override SapphireModelCondition's initCondition() method. But the overridden method need to call super's initCondition() method to ensure that model dependencies and listeners are handled properly.

Failure to do that would result the conditions never re-evaluated when the corresponding model properties change.

We need to add some documentation in regard to this issue in the Sapphire 0.2 migration guide.

Reproducible: Always
Comment 1 Konstantin Komissarchik CLA 2011-01-18 20:10:49 EST
Added some wording about this to the migration guide. Please verify.
Comment 2 Shenxue Zhou CLA 2011-02-02 16:02:37 EST
Just the release doc and found this note:

It is important that any subclass of SapphireModelCondition that overrides initCondition() method, also calls the super implementation of this method. Failing to do that will prevent the condition from refreshing on dependent property changes.
Comment 3 Konstantin Komissarchik CLA 2011-02-24 21:11:53 EST
Closing.