Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334684 - Backport to 3.2.x SystemViewForm dialogs don't display cancellable progress in the dialog
Summary: Backport to 3.2.x SystemViewForm dialogs don't display cancellable progress i...
Status: RESOLVED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.2.2+   Edit
Assignee: David McKnight CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords:
Depends on: 334295
Blocks:
  Show dependency tree
 
Reported: 2011-01-18 13:42 EST by David McKnight CLA
Modified: 2011-03-22 14:57 EDT (History)
1 user (show)

See Also:
xuanchen: review+


Attachments
backport patch (7.93 KB, patch)
2011-03-22 13:01 EDT, David McKnight CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David McKnight CLA 2011-01-18 13:42:01 EST
This bug is for the backport of the fix for bug 334295 to the R3_2_maintenance stream.
Comment 1 David McKnight CLA 2011-03-22 13:01:44 EDT
Created attachment 191700 [details]
backport patch
Comment 2 David McKnight CLA 2011-03-22 13:07:20 EDT
The patch uses the following Eclipse Platform non-API:
    org.eclipse.ui.internal.progress.ProgressMessages

Since we cannot add MRI in the maintenance stream, I think use of non-API may be the only way to provide an appropriate fetching string.  Note that in the HEAD stream (bug 334295) we do introduce a new string so we don't have to use the internal reference.
Comment 3 David McKnight CLA 2011-03-22 13:07:33 EDT
Xuan, could you please review the patch?
Comment 4 Xuan Chen CLA 2011-03-22 14:10:39 EDT
The fix looks good (I've reviewed the fix contents in 3.3 release).  Thanks.
Comment 5 David McKnight CLA 2011-03-22 14:57:19 EDT
Thanks Xuan.  I've committed the change to cvs.