Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334646 - [Discovery] Popup menu with UI for parameter values
Summary: [Discovery] Popup menu with UI for parameter values
Status: CLOSED FIXED
Alias: None
Product: MoDisco
Classification: Modeling
Component: Infrastructure (show other bugs)
Version: 0.9.0   Edit
Hardware: PC Windows 7
: P3 normal (vote)
Target Milestone: 0.9.0 M5   Edit
Assignee: Nicolas Bros CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-18 09:18 EST by Nicolas Bros CLA
Modified: 2011-08-18 07:41 EDT (History)
2 users (show)

See Also:
nicolas.bros: indigo+

Attachments
patch (40.87 KB, patch)
2011-01-18 09:45 EST, Nicolas Bros CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Bros CLA 2011-01-18 09:18:06 EST 
We need to reinstate the MoDisco sub-menu that appears in the context menu on any selection.
Comment 1 Nicolas Bros CLA 2011-01-18 09:45:15 EST 
Created attachment 187001 [details]
patch

Here is a patch.

New extension point: org.eclipse.modisco.infra.discovery.ui.discoverer_ui
It allows to register the UI part of a discoverer in the discoverers registry, so that it appears in the MoDisco menu of discoverers.

The extension is defined in org.eclipse.modisco.infra.discovery.ui.
And JUnit tests in org.eclipse.modisco.infra.discovery.ui.tests.

The MoDisco menu is dynamic (ContributionItemForMoDiscoMenu), and when a discoverer is clicked (MoDiscoMenuSelectionListener), and parameters are entered by the user (GenericParametersDialog), the discoverer is called with the parameters in a Job.
Comment 2 Nicolas Bros CLA 2011-01-18 10:27:06 EST 
This patch has to be adapted based on the refactoring to use an ecore model for representing discoverers.
Comment 3 Nicolas Bros CLA 2011-01-19 09:04:53 EST 
I adapted the patch and committed it and the test plug-in in revision 3760.
Comment 4 Hugo Bruneliere CLA 2011-08-18 07:41:16 EDT 
Upgrade done.