Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334607 - UndeclaredThrowableException when read times out during validation
Summary: UndeclaredThrowableException when read times out during validation
Status: RESOLVED FIXED
Alias: None
Product: z_Archived
Classification: Eclipse Foundation
Component: Mylyn (show other bugs)
Version: unspecified   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 0.7   Edit
Assignee: Steffen Pingel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-17 23:35 EST by Steffen Pingel CLA
Modified: 2011-02-12 22:37 EST (History)
0 users

See Also:

Attachments
mylyn/context/zip (1.74 KB, application/octet-stream)
2011-02-12 22:37 EST, Steffen Pingel CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Steffen Pingel CLA 2011-01-17 23:35:27 EST 
Error handling needs to be improved:

java.lang.reflect.UndeclaredThrowableException
at $Proxy0.myAccount(Unknown Source)
at org.eclipse.mylyn.internal.gerrit.core.client.GerritClient$2.execute(GerritClient.java:128)
at org.eclipse.mylyn.internal.gerrit.core.client.GerritClient.execute(GerritClient.java:269)
at org.eclipse.mylyn.internal.gerrit.core.client.GerritClient.getInfo(GerritClient.java:125)
at org.eclipse.mylyn.internal.gerrit.core.GerritConnector.validate(GerritConnector.java:234)
at org.eclipse.mylyn.internal.gerrit.ui.GerritRepositorySettingsPage$GerritValidator.run(GerritRepositorySettingsPage.java:125)
at org.eclipse.mylyn.tasks.ui.wizards.AbstractRepositorySettingsPage$25.run(AbstractRepositorySettingsPage.java:1668)
at org.eclipse.jface.operation.ModalContext$ModalContextThread.run(ModalContext.java:121)
Caused by: java.net.SocketTimeoutException: Read timed out
at java.net.SocketInputStream.socketRead0(Native Method)
at java.net.SocketInputStream.read(SocketInputStream.java:129)
at java.io.BufferedInputStream.fill(BufferedInputStream.java:218)
at java.io.BufferedInputStream.read(BufferedInputStream.java:237)
at org.apache.commons.httpclient.HttpParser.readRawLine(HttpParser.java:78)
at org.apache.commons.httpclient.HttpParser.readLine(HttpParser.java:106)
at org.apache.commons.httpclient.HttpConnection.readLine(HttpConnection.java:1116)
at org.apache.commons.httpclient.MultiThreadedHttpConnectionManager$HttpConnectionAdapter.readLine(MultiThreadedHttpConnectionManager.java:1413)
at org.apache.commons.httpclient.HttpMethodBase.readStatusLine(HttpMethodBase.java:1973)
at org.apache.commons.httpclient.HttpMethodBase.readResponse(HttpMethodBase.java:1735)
at org.apache.commons.httpclient.HttpMethodBase.execute(HttpMethodBase.java:1098)
at org.apache.commons.httpclient.HttpMethodDirector.executeWithRetry(HttpMethodDirector.java:398)
at org.apache.commons.httpclient.HttpMethodDirector.executeMethod(HttpMethodDirector.java:171)
at org.apache.commons.httpclient.HttpClient.executeMethod(HttpClient.java:397)
at org.eclipse.mylyn.commons.net.WebUtil$2.execute(WebUtil.java:333)
at org.eclipse.mylyn.commons.net.WebUtil$2.execute(WebUtil.java:1)
at org.eclipse.mylyn.internal.commons.net.MonitoredRequest.call(MonitoredRequest.java:51)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:303)
at java.util.concurrent.FutureTask.run(FutureTask.java:138)
at java.util.concurrent.ThreadPoolExecutor$Worker.runTask(ThreadPoolExecutor.java:886)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:908)
at java.lang.Thread.run(Thread.java:662)
Comment 1 Steffen Pingel CLA 2011-02-12 22:37:04 EST 
Steps:
1. Enter invalid URL
2. Validate

The exception originates from GerritService.invoke().

Caused by: java.net.UnknownHostException: foo
	at java.net.PlainSocketImpl.connect(PlainSocketImpl.java:177)
	at java.net.SocksSocketImpl.connect(SocksSocketImpl.java:366)
	at java.net.Socket.connect(Socket.java:529)
	at org.eclipse.mylyn.internal.commons.net.MonitoredRequest.connect(MonitoredRequest.java:97)
	at org.eclipse.mylyn.internal.commons.net.PollingProtocolSocketFactory.createSocket(PollingProtocolSocketFactory.java:54)
	at org.apache.commons.httpclient.HttpConnection.open(HttpConnection.java:707)
Comment 2 Steffen Pingel CLA 2011-02-12 22:37:48 EST 
Committed fix to handle exception. Also fixed anonymous login and an endless loop on authentication failure.
Comment 3 Steffen Pingel CLA 2011-02-12 22:37:51 EST 
Created attachment 188844 [details]
mylyn/context/zip