Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.
Bug 334592 - IWorkbenchHelpSystem#displayHelpResource() no longer works for file: URLs
Summary: IWorkbenchHelpSystem#displayHelpResource() no longer works for file: URLs
Status: RESOLVED FIXED
Alias: None
Product: Platform
Classification: Eclipse Project
Component: User Assistance (show other bugs)
Version: 3.6.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.7 M6   Edit
Assignee: Chris Goldthorpe CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-01-17 17:44 EST by Eric Chan CLA
Modified: 2011-02-10 13:27 EST (History)
1 user (show)

See Also:


Attachments
Patch (2.81 KB, patch)
2011-02-10 13:26 EST, Chris Goldthorpe CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Chan CLA 2011-01-17 17:44:50 EST
Build Identifier: M20100909-0800

We have external help on the local filesystem that we're displaying through the API org.eclipse.ui.help.IWorkbenchHelpSystem.displayHelpResource().

We pass in a file: URL, such as "file:///C:/test.html".

This worked for us in Eclipse 3.4 - our help contents were displayed in the internal browser.

In 3.6 this no longer works.  The internal browser opens but just displays the default general info page.

If I append "?noframes=true" to the end of the URL, and pass it into displayHelpResource(), then an external browser does open and display our help contents.  However, we'd prefer to continue to use the internal browser.

Reproducible: Always

Steps to Reproduce:
1. Open a local filesystem URL through the API call:

PlatformUI.getWorkbench().getHelpSystem().displayHelpResource("file:///C:/test.html");
Comment 1 Chris Goldthorpe CLA 2011-01-17 19:32:35 EST
This is a side effect of the fix for Bug 319344. I think that it should be possible to fix this bug without causing Bug 319344 to regress.
Comment 2 Chris Goldthorpe CLA 2011-02-10 13:26:06 EST
Created attachment 188710 [details]
Patch
Comment 3 Chris Goldthorpe CLA 2011-02-10 13:27:12 EST
Patch applied to HEAD, Fixed